Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: lib/html/dart2js/html_dart2js.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: lib/html/dart2js/html_dart2js.dart
diff --git a/lib/html/dart2js/html_dart2js.dart b/lib/html/dart2js/html_dart2js.dart
index 85c4e3bf77c9993fe844039d408d2fe90c825ef2..2ca1335068831a7bfd164569890e83fca5d81746 100644
--- a/lib/html/dart2js/html_dart2js.dart
+++ b/lib/html/dart2js/html_dart2js.dart
@@ -10490,7 +10490,7 @@ class FilteredElementList implements ElementList {
if (newLength >= len) {
return;
} else if (newLength < 0) {
- throw const IllegalArgumentException("Invalid list length");
+ throw const ArgumentError("Invalid list length");
}
removeRange(newLength - 1, len - newLength);
@@ -10642,7 +10642,7 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment native
this.nodes.add(node);
return node;
default:
- throw new IllegalArgumentException("Invalid position ${where}");
+ throw new ArgumentError("Invalid position ${where}");
}
}
@@ -12378,7 +12378,7 @@ class _ElementImpl extends _NodeImpl implements Element native "*Element" {
this.parent.insertBefore(node, this.nextNode);
break;
default:
- throw new IllegalArgumentException("Invalid position ${where}");
+ throw new ArgumentError("Invalid position ${where}");
}
}
@@ -12560,7 +12560,7 @@ class _ElementFactoryProvider {
// only contains a head or body element.
element = temp.elements[tag == 'head' ? 0 : 1];
} else {
- throw new IllegalArgumentException('HTML had ${temp.elements.length} '
+ throw new ArgumentError('HTML had ${temp.elements.length} '
'top level elements but 1 expected');
}
element.remove();
@@ -16036,7 +16036,7 @@ class _IDBDatabaseImpl extends _EventTargetImpl implements IDBDatabase native "*
_IDBTransactionImpl transaction(storeName_OR_storeNames, String mode) {
if (mode != 'readonly' && mode != 'readwrite') {
- throw new IllegalArgumentException(mode);
+ throw new ArgumentError(mode);
}
// TODO(sra): Ensure storeName_OR_storeNames is a string, List<String> or
@@ -20310,7 +20310,7 @@ class _MutationObserverImpl implements MutationObserver native "*MutationObserve
} else if (k == 'attributeFilter') {
_add(parsedOptions, k, _fixupList(v));
} else {
- throw new IllegalArgumentException(
+ throw new ArgumentError(
"Illegal MutationObserver.observe option '$k'");
}
});
@@ -41146,7 +41146,7 @@ class _SVGElementFactoryProvider {
parentTag.innerHTML = svg;
if (parentTag.elements.length == 1) return parentTag.nodes.removeLast();
- throw new IllegalArgumentException(
+ throw new ArgumentError(
'SVG had ${parentTag.elements.length} '
'top-level elements but 1 expected');
}
@@ -42041,12 +42041,12 @@ class _Lists {
* Returns a sub list copy of this list, from [start] to
* [:start + length:].
* Returns an empty list if [length] is 0.
- * Throws an [IllegalArgumentException] if [length] is negative.
+ * Throws an [ArgumentError] if [length] is negative.
* Throws an [IndexOutOfRangeException] if [start] or
* [:start + length:] are out of range.
*/
static List getRange(List a, int start, int length, List accumulator) {
- if (length < 0) throw new IllegalArgumentException('length');
+ if (length < 0) throw new ArgumentError('length');
if (start < 0) throw new IndexOutOfRangeException(start);
int end = start + length;
if (end > a.length) throw new IndexOutOfRangeException(end);

Powered by Google App Engine
This is Rietveld 408576698