Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: runtime/bin/file_impl.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/file_impl.dart
diff --git a/runtime/bin/file_impl.dart b/runtime/bin/file_impl.dart
index fef7bc0bd031221efedb136edc9e22e8781bcf3b..145e4db197d8746f984d459fa2b03ddd78496ea8 100644
--- a/runtime/bin/file_impl.dart
+++ b/runtime/bin/file_impl.dart
@@ -393,56 +393,56 @@ class _FileUtils {
static SendPort newServicePort() native "File_NewServicePort";
static bool checkedExists(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = exists(name);
throwIfError(result, "Cannot check existence of file '$name'");
return result;
}
static int checkedOpen(String name, int mode) {
- if (name is !String || mode is !int) throw new IllegalArgumentException();
+ if (name is !String || mode is !int) throw new ArgumentError();
var result = open(name, mode);
throwIfError(result, "Cannot open file '$name'");
return result;
}
static bool checkedCreate(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = create(name);
throwIfError(result, "Cannot create file '$name'");
return true;
}
static bool checkedDelete(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = delete(name);
throwIfError(result, "Cannot delete file '$name'");
return true;
}
static String checkedFullPath(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = fullPath(name);
throwIfError(result, "Cannot retrieve full path for file '$name'");
return result;
}
static String checkedDirectory(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = directory(name);
throwIfError(result, "Cannot retrieve directory for file '$name'");
return result;
}
static int checkedLengthFromName(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = lengthFromName(name);
throwIfError(result, "Cannot retrieve length of file '$name'");
return result;
}
static int checkedLastModified(String name) {
- if (name is !String) throw new IllegalArgumentException();
+ if (name is !String) throw new ArgumentError();
var result = lastModified(name);
throwIfError(result, "Cannot retrieve modification time for file '$name'");
return result;
@@ -456,7 +456,7 @@ class _FileUtils {
}
static int checkedWriteString(int id, String string) {
- if (string is !String) throw new IllegalArgumentException();
+ if (string is !String) throw new ArgumentError();
return writeString(id, string);
}
@@ -477,7 +477,7 @@ class _FileBase {
assert(_isErrorResponse(response));
switch (response[_FileUtils.ERROR_RESPONSE_ERROR_TYPE]) {
case _FileUtils.ILLEGAL_ARGUMENT_RESPONSE:
- return new IllegalArgumentException();
+ return new ArgumentError();
case _FileUtils.OSERROR_RESPONSE:
var err = new OSError(response[_FileUtils.OSERROR_RESPONSE_MESSAGE],
response[_FileUtils.OSERROR_RESPONSE_ERROR_CODE]);
@@ -579,7 +579,7 @@ class _File extends _FileBase implements File {
mode != FileMode.WRITE &&
mode != FileMode.APPEND) {
new Timer(0, (t) {
- completer.completeException(new IllegalArgumentException());
+ completer.completeException(new ArgumentError());
});
return completer.future;
}

Powered by Google App Engine
This is Rietveld 408576698