Clean up a few TODO items.

Clean up a few TODO items.

Push UnhandledWheelEvent and GetBrowserAccessibilityManager down to RenderWidgetHostViewPort.

Get rid of OnMessageReceivedForTesting, in favor of RenderViewHostTester::TestOnMessageReceived (which already existed but needed to be converted to a static method so it could be used with regular RenderViewHost instances).

Rename WebContentsTester::pending_rvh() to GetPendingRvh() since it's a virtual method.

Remove top-level alias for content::RenderViewHostTestHarness and switch clients to use the fully-qualified name.

Clean up a couple of other minor TODO items, some had already been done and the comment just needed to be removed; in one case the TODO was just wrong (in dump_accessibility_tree_browsertest.cc) since it's OK for content to depend on content implementations.

Remove test_tab_contents.h from DEPS (seems to have been a merge failure in my last change that left this in).

BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128263

[jam, 2012-03-22 17:15:41]

lgtm

http://codereview.chromium.org/9838009/diff/1132/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

http://codereview.chromium.org/9838009/diff/1132/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:24:
#include "content/port/browser/render_widget_host_view_port.h"
nit: order

http://codereview.chromium.org/9838009/diff/1132/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

http://codereview.chromium.org/9838009/diff/1132/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_mac.h:296: 
nit: no need for blank line between overridden functions

http://codereview.chromium.org/9838009/diff/1132/content/test/web_contents_te...
File content/test/web_contents_tester.h (right):

http://codereview.chromium.org/9838009/diff/1132/content/test/web_contents_te...
content/test/web_contents_tester.h:87: virtual content::RenderViewHost*
GetPendingRvh() const = 0;
nit: since RVH is an acronym it should be GetPendingRVH. or even better, just
GetPendingRenderViewHost to match the rest of the code which usually doesn't
shorten it (i.e. this method calls out to pending_render_view_host() I believe).

[Jói, 2012-03-22 17:39:58]

http://codereview.chromium.org/9838009/diff/1132/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

http://codereview.chromium.org/9838009/diff/1132/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:24:
#include "content/port/browser/render_widget_host_view_port.h"
On 2012/03/22 17:15:41, John Abd-El-Malek wrote:
> nit: order

Done.

http://codereview.chromium.org/9838009/diff/1132/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

http://codereview.chromium.org/9838009/diff/1132/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_mac.h:296: 
On 2012/03/22 17:15:41, John Abd-El-Malek wrote:
> nit: no need for blank line between overridden functions

Done.

http://codereview.chromium.org/9838009/diff/1132/content/test/web_contents_te...
File content/test/web_contents_tester.h (right):

http://codereview.chromium.org/9838009/diff/1132/content/test/web_contents_te...
content/test/web_contents_tester.h:87: virtual content::RenderViewHost*
GetPendingRvh() const = 0;
On 2012/03/22 17:15:41, John Abd-El-Malek wrote:
> nit: since RVH is an acronym it should be GetPendingRVH. or even better, just
> GetPendingRenderViewHost to match the rest of the code which usually doesn't
> shorten it (i.e. this method calls out to pending_render_view_host() I
believe).

Done.

[commit-bot: I haz the power, 2012-03-22 17:41:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/9838009/8001

[commit-bot: I haz the power, 2012-03-22 19:05:07]

Change committed as 128263