Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: content/browser/tab_contents/render_view_host_manager_unittest.cc

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/render_view_host_manager_unittest.cc
diff --git a/content/browser/tab_contents/render_view_host_manager_unittest.cc b/content/browser/tab_contents/render_view_host_manager_unittest.cc
index 27628423760ba195eb03520689d52495ba720ebc..820f93e2cdeaefae413b4d1190afc17d1019a57f 100644
--- a/content/browser/tab_contents/render_view_host_manager_unittest.cc
+++ b/content/browser/tab_contents/render_view_host_manager_unittest.cc
@@ -269,7 +269,7 @@ TEST_F(RenderViewHostManagerTest, FilterMessagesWhileSwappedOut) {
// Send an update title message and make sure it works.
const string16 ntp_title = ASCIIToUTF16("NTP Title");
WebKit::WebTextDirection direction = WebKit::WebTextDirectionLeftToRight;
- EXPECT_TRUE(ntp_rvh->TestOnMessageReceived(
+ EXPECT_TRUE(ntp_rvh->OnMessageReceived(
ViewHostMsg_UpdateTitle(rvh()->GetRoutingID(), 0, ntp_title, direction)));
EXPECT_EQ(ntp_title, contents()->GetTitle());
@@ -291,7 +291,7 @@ TEST_F(RenderViewHostManagerTest, FilterMessagesWhileSwappedOut) {
// The new RVH should be able to update its title.
const string16 dest_title = ASCIIToUTF16("Google");
- EXPECT_TRUE(dest_rvh->TestOnMessageReceived(
+ EXPECT_TRUE(dest_rvh->OnMessageReceived(
ViewHostMsg_UpdateTitle(rvh()->GetRoutingID(), 101, dest_title,
direction)));
EXPECT_EQ(dest_title, contents()->GetTitle());
@@ -299,7 +299,7 @@ TEST_F(RenderViewHostManagerTest, FilterMessagesWhileSwappedOut) {
// The old renderer, being slow, now updates the title. It should be filtered
// out and not take effect.
EXPECT_TRUE(ntp_rvh->is_swapped_out());
- EXPECT_TRUE(ntp_rvh->TestOnMessageReceived(
+ EXPECT_TRUE(ntp_rvh->OnMessageReceived(
ViewHostMsg_UpdateTitle(rvh()->GetRoutingID(), 0, ntp_title, direction)));
EXPECT_EQ(dest_title, contents()->GetTitle());
@@ -317,7 +317,7 @@ TEST_F(RenderViewHostManagerTest, FilterMessagesWhileSwappedOut) {
rvh()->GetRoutingID(), kNtpUrl, msg, false, &result, &unused);
// Enable pumping for check in BrowserMessageFilter::CheckCanDispatchOnUI.
before_unload_msg.EnableMessagePumping();
- EXPECT_TRUE(ntp_rvh->TestOnMessageReceived(before_unload_msg));
+ EXPECT_TRUE(ntp_rvh->OnMessageReceived(before_unload_msg));
EXPECT_TRUE(ntp_process_host->sink().GetUniqueMessageMatching(IPC_REPLY_ID));
// Also test RunJavaScriptMessage.
@@ -326,7 +326,7 @@ TEST_F(RenderViewHostManagerTest, FilterMessagesWhileSwappedOut) {
rvh()->GetRoutingID(), msg, msg, kNtpUrl,
ui::JAVASCRIPT_MESSAGE_TYPE_CONFIRM, &result, &unused);
js_msg.EnableMessagePumping();
- EXPECT_TRUE(ntp_rvh->TestOnMessageReceived(js_msg));
+ EXPECT_TRUE(ntp_rvh->OnMessageReceived(js_msg));
EXPECT_TRUE(ntp_process_host->sink().GetUniqueMessageMatching(IPC_REPLY_ID));
}
@@ -351,7 +351,7 @@ TEST_F(RenderViewHostManagerTest, AlwaysSendEnableViewSourceMode) {
controller().LoadURL(
kUrl, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
// Simulate response from RenderView for FirePageBeforeUnload.
- test_rvh()->TestOnMessageReceived(ViewHostMsg_ShouldClose_ACK(
+ test_rvh()->OnMessageReceived(ViewHostMsg_ShouldClose_ACK(
rvh()->GetRoutingID(), true, base::TimeTicks(), base::TimeTicks()));
ASSERT_TRUE(pending_rvh()); // New pending RenderViewHost will be created.
RenderViewHost* last_rvh = pending_rvh();

Powered by Google App Engine
This is Rietveld 408576698