Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: content/public/browser/render_widget_host.h

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_
6 #define CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_ 6 #define CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/keyboard_listener.h" 10 #include "content/public/browser/keyboard_listener.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 // Stops loading the page. 258 // Stops loading the page.
259 virtual void Stop() = 0; 259 virtual void Stop() = 0;
260 260
261 // Called to notify the RenderWidget that it has been resized. 261 // Called to notify the RenderWidget that it has been resized.
262 virtual void WasResized() = 0; 262 virtual void WasResized() = 0;
263 263
264 // Access to the implementation's 264 // Access to the implementation's
265 // IPC::Channel::Listener::OnMessageReceived. Intended only for 265 // IPC::Channel::Listener::OnMessageReceived. Intended only for
266 // test code. 266 // test code.
267 267
268 // TODO(joi): Remove this and convert the single test using it to
269 // get the TabContentsWrapper from
270 // browser()->GetSelectedWebContents() and then call its
271 // translate_tab_helper() to get at the object that dispatches its
272 // method.
273 virtual bool OnMessageReceivedForTesting(const IPC::Message& msg) = 0;
274
275 // Add a keyboard listener that can handle key presses without requiring 268 // Add a keyboard listener that can handle key presses without requiring
276 // focus. 269 // focus.
277 virtual void AddKeyboardListener(KeyboardListener* listener) = 0; 270 virtual void AddKeyboardListener(KeyboardListener* listener) = 0;
278 271
279 // Remove a keyboard listener. 272 // Remove a keyboard listener.
280 virtual void RemoveKeyboardListener(KeyboardListener* listener) = 0; 273 virtual void RemoveKeyboardListener(KeyboardListener* listener) = 0;
281 274
282 protected: 275 protected:
283 friend class RenderWidgetHostImpl; 276 friend class RenderWidgetHostImpl;
284 277
285 // Retrieves the implementation class. Intended only for code 278 // Retrieves the implementation class. Intended only for code
286 // within content/. This method is necessary because 279 // within content/. This method is necessary because
287 // RenderWidgetHost is the root of a diamond inheritance pattern, so 280 // RenderWidgetHost is the root of a diamond inheritance pattern, so
288 // subclasses inherit it virtually, which removes our ability to 281 // subclasses inherit it virtually, which removes our ability to
289 // static_cast to the subclass. 282 // static_cast to the subclass.
290 virtual RenderWidgetHostImpl* AsRenderWidgetHostImpl() = 0; 283 virtual RenderWidgetHostImpl* AsRenderWidgetHostImpl() = 0;
291 }; 284 };
292 285
293 } // namespace content 286 } // namespace content
294 287
295 #endif // CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_ 288 #endif // CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_
OLDNEW
« no previous file with comments | « content/port/browser/render_widget_host_view_port.h ('k') | content/public/browser/render_widget_host_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698