Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: content/test/web_contents_tester.h

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_TEST_WEB_CONTENTS_TESTER_H_ 5 #ifndef CONTENT_TEST_WEB_CONTENTS_TESTER_H_
6 #define CONTENT_TEST_WEB_CONTENTS_TESTER_H_ 6 #define CONTENT_TEST_WEB_CONTENTS_TESTER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/public/common/page_transition_types.h" 9 #include "content/public/common/page_transition_types.h"
10 10
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 // Simulates the appropriate RenderView (pending if any, current otherwise) 77 // Simulates the appropriate RenderView (pending if any, current otherwise)
78 // sending a navigate notification for the NavigationController pending entry. 78 // sending a navigate notification for the NavigationController pending entry.
79 virtual void CommitPendingNavigation() = 0; 79 virtual void CommitPendingNavigation() = 0;
80 80
81 // Only implementations retrieved via the deprecated 81 // Only implementations retrieved via the deprecated
82 // CreateTestWebContentsFor... methods above will implement this 82 // CreateTestWebContentsFor... methods above will implement this
83 // method. It retrieves the number of times the focus-related calls 83 // method. It retrieves the number of times the focus-related calls
84 // in question have been made. 84 // in question have been made.
85 virtual int GetNumberOfFocusCalls() = 0; 85 virtual int GetNumberOfFocusCalls() = 0;
86 86
87 // TODO(joi): Rename this and other hacker_style virtual methods. 87 virtual content::RenderViewHost* GetPendingRvh() const = 0;
jam 2012/03/22 17:15:41 nit: since RVH is an acronym it should be GetPendi
Jói 2012/03/22 17:39:58 Done.
88 virtual content::RenderViewHost* pending_rvh() const = 0;
89 88
90 // Creates a pending navigation to the given URL with the default parameters 89 // Creates a pending navigation to the given URL with the default parameters
91 // and then commits the load with a page ID one larger than any seen. This 90 // and then commits the load with a page ID one larger than any seen. This
92 // emulates what happens on a new navigation. 91 // emulates what happens on a new navigation.
93 virtual void NavigateAndCommit(const GURL& url) = 0; 92 virtual void NavigateAndCommit(const GURL& url) = 0;
94 93
95 // Simulates the current RVH notifying that it has unloaded so that the 94 // Simulates the current RVH notifying that it has unloaded so that the
96 // pending RVH navigation can proceed. 95 // pending RVH navigation can proceed.
97 // Does nothing if no cross-navigation is pending. 96 // Does nothing if no cross-navigation is pending.
98 virtual void ProceedWithCrossSiteNavigation() = 0; 97 virtual void ProceedWithCrossSiteNavigation() = 0;
(...skipping 10 matching lines...) Expand all
109 const content::Referrer& referrer, 108 const content::Referrer& referrer,
110 content::PageTransition transition) = 0; 109 content::PageTransition transition) = 0;
111 110
112 // Promote GetWebkitPrefs to public. 111 // Promote GetWebkitPrefs to public.
113 virtual WebPreferences TestGetWebkitPrefs() = 0; 112 virtual WebPreferences TestGetWebkitPrefs() = 0;
114 }; 113 };
115 114
116 } // namespace content 115 } // namespace content
117 116
118 #endif // CONTENT_TEST_WEB_CONTENTS_TESTER_H_ 117 #endif // CONTENT_TEST_WEB_CONTENTS_TESTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698