Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 #pragma once 7 #pragma once
8 8
9 #if defined(OS_MACOSX) 9 #if defined(OS_MACOSX)
10 #include <OpenGL/OpenGL.h> 10 #include <OpenGL/OpenGL.h>
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 virtual ~RenderWidgetHostViewBase(); 42 virtual ~RenderWidgetHostViewBase();
43 43
44 // RenderWidgetHostViewPort implementation. 44 // RenderWidgetHostViewPort implementation.
45 virtual void SelectionChanged(const string16& text, 45 virtual void SelectionChanged(const string16& text,
46 size_t offset, 46 size_t offset,
47 const ui::Range& range) OVERRIDE; 47 const ui::Range& range) OVERRIDE;
48 virtual void SetBackground(const SkBitmap& background) OVERRIDE; 48 virtual void SetBackground(const SkBitmap& background) OVERRIDE;
49 virtual const SkBitmap& GetBackground() OVERRIDE; 49 virtual const SkBitmap& GetBackground() OVERRIDE;
50 virtual bool IsShowingContextMenu() const OVERRIDE; 50 virtual bool IsShowingContextMenu() const OVERRIDE;
51 virtual void SetShowingContextMenu(bool showing_menu) OVERRIDE; 51 virtual void SetShowingContextMenu(bool showing_menu) OVERRIDE;
52 virtual bool IsMouseLocked() OVERRIDE;
53 virtual void UnhandledWheelEvent(
54 const WebKit::WebMouseWheelEvent& event) OVERRIDE;
55 virtual void SetPopupType(WebKit::WebPopupType popup_type) OVERRIDE;
56 virtual WebKit::WebPopupType GetPopupType() OVERRIDE;
52 virtual BrowserAccessibilityManager* 57 virtual BrowserAccessibilityManager*
53 GetBrowserAccessibilityManager() const OVERRIDE; 58 GetBrowserAccessibilityManager() const OVERRIDE;
54 virtual bool IsMouseLocked() OVERRIDE;
55 virtual void SetPopupType(WebKit::WebPopupType popup_type) OVERRIDE;
56 virtual WebKit::WebPopupType GetPopupType() OVERRIDE;
57 59
58 void SetBrowserAccessibilityManager(BrowserAccessibilityManager* manager); 60 void SetBrowserAccessibilityManager(BrowserAccessibilityManager* manager);
59 61
60 protected: 62 protected:
61 // Interface class only, do not construct. 63 // Interface class only, do not construct.
62 RenderWidgetHostViewBase(); 64 RenderWidgetHostViewBase();
63 65
64 // Whether this view is a popup and what kind of popup it is (select, 66 // Whether this view is a popup and what kind of popup it is (select,
65 // autofill...). 67 // autofill...).
66 WebKit::WebPopupType popup_type_; 68 WebKit::WebPopupType popup_type_;
(...skipping 25 matching lines...) Expand all
92 private: 94 private:
93 // Manager of the tree representation of the WebKit render tree. 95 // Manager of the tree representation of the WebKit render tree.
94 scoped_ptr<BrowserAccessibilityManager> browser_accessibility_manager_; 96 scoped_ptr<BrowserAccessibilityManager> browser_accessibility_manager_;
95 97
96 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 98 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
97 }; 99 };
98 100
99 } // namespace content 101 } // namespace content
100 102
101 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 103 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698