content/test/web_contents_tester.h - Issue 9838009: Clean up a few TODO items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/web_contents_tester.h

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/web_contents_tester.h

diff --git a/content/test/web_contents_tester.h b/content/test/web_contents_tester.h

index 1729404858fe62884eea114fcb2b1df42c591f0c..9ede723ce89033f552883133b0bc0adf89417a7c 100644

--- a/content/test/web_contents_tester.h

+++ b/content/test/web_contents_tester.h

@@ -84,8 +84,7 @@ class WebContentsTester {

// in question have been made.

virtual int GetNumberOfFocusCalls() = 0;

- // TODO(joi): Rename this and other hacker_style virtual methods.

- virtual content::RenderViewHost* pending_rvh() const = 0;

+ virtual content::RenderViewHost* GetPendingRenderViewHost() const = 0;

// Creates a pending navigation to the given URL with the default parameters

// and then commits the load with a page ID one larger than any seen. This

« no previous file with comments | « content/test/test_renderer_host.cc ('k') | no next file » | no next file with comments »