Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 0de5cea6b81da2e81994926a93410d87a5f8cf9d..d7760e9a12d733f3beceba88c9c1185f55bfa5bb 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -50,11 +50,6 @@ const SkBitmap& RenderWidgetHostViewBase::GetBackground() {
return background_;
}
-BrowserAccessibilityManager*
- RenderWidgetHostViewBase::GetBrowserAccessibilityManager() const {
- return browser_accessibility_manager_.get();
-}
-
void RenderWidgetHostViewBase::SelectionChanged(const string16& text,
size_t offset,
const ui::Range& range) {
@@ -77,6 +72,11 @@ bool RenderWidgetHostViewBase::IsMouseLocked() {
return mouse_locked_;
}
+void RenderWidgetHostViewBase::UnhandledWheelEvent(
+ const WebKit::WebMouseWheelEvent& event) {
+ // Most implementations don't need to do anything here.
+}
+
void RenderWidgetHostViewBase::SetPopupType(WebKit::WebPopupType popup_type) {
popup_type_ = popup_type;
}
@@ -85,6 +85,11 @@ WebKit::WebPopupType RenderWidgetHostViewBase::GetPopupType() {
return popup_type_;
}
+BrowserAccessibilityManager*
+ RenderWidgetHostViewBase::GetBrowserAccessibilityManager() const {
+ return browser_accessibility_manager_.get();
+}
+
void RenderWidgetHostViewBase::SetBrowserAccessibilityManager(
BrowserAccessibilityManager* manager) {
browser_accessibility_manager_.reset(manager);

Powered by Google App Engine
This is Rietveld 408576698