content/browser/accessibility/dump_accessibility_tree_browsertest.cc - Issue 9838009: Clean up a few TODO items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/base/chrome_render_view_host_test_harness.cc ('k') | content/browser/intents/internal_web_intents_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

index 89e96a4bad872c18b3ea1331e5035b563279b099..786962d50a39b128721c32ac1e24a4f4e8ebcfa6 100644

--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

@@ -17,9 +17,9 @@

#include "content/browser/accessibility/browser_accessibility_manager.h"

#include "content/browser/accessibility/dump_accessibility_tree_helper.h"

#include "content/browser/renderer_host/render_view_host_impl.h"

+#include "content/port/browser/render_widget_host_view_port.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

-#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/content_paths.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -28,6 +28,7 @@ using content::OpenURLParams;

using content::RenderViewHostImpl;

using content::RenderWidgetHostImpl;

using content::RenderWidgetHost;

+using content::RenderWidgetHostViewPort;

using content::Referrer;

namespace {

@@ -76,10 +77,9 @@ class DumpAccessibilityTreeTest : public InProcessBrowserTest {

IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,

PlatformTreeDifferenceTest) {

- content::RenderWidgetHostView* host_view =

- browser()->GetSelectedWebContents()->GetRenderWidgetHostView();

+ RenderWidgetHostViewPort* host_view = static_cast<RenderWidgetHostViewPort*>(

+ browser()->GetSelectedWebContents()->GetRenderWidgetHostView());

RenderWidgetHost* host = host_view->GetRenderWidgetHost();

- // TODO(joi): Remove this dependency

RenderViewHostImpl* view_host =

static_cast<RenderViewHostImpl*>(RenderWidgetHostImpl::From(host));

view_host->set_save_accessibility_tree_for_testing(true);