Modify WaitableEvent::Wait() to return void

Modify WaitableEvent::Wait() to return void

Currently, WaitableEvent::Wait() returns bool. However, the Windows
implementation DCHECKs that the return value is true and the POSIX
implementation can never return false. Also, all call sites that use the return
value simply DCHECK that it's true.

This change modifies the method to return void, adds a DCHECK in the POSIX
implementation and updates call sites.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104990

[Steve Block, 2011-10-10 22:33:40]

Hi Brett,

I noticed that the boolean return value of WaitableEvent::Wait() isn't really
used. The Windows implementation DCHECKs that the result is true, and it looks
like the POSIX implementation must always return true. Also, all call sites that
use the return value just DCHECK that it's true.

What's the motivation for the method retuning a boolean? Is it simply for
consistency with TimedWait()? Perhaps we should remove the return value and/or
add a DCHECK in the POSIX implementation?

I've uploaded a patch as context for my question.

Thanks,
Steve

[Steve Block, 2011-10-11 14:25:36]

Switching reviewer from brettw to willchan as brettw will soon be taking leave.

[willchan no longer on Chromium, 2011-10-11 15:04:54]

LGTM

http://codereview.chromium.org/8221021/diff/1001/base/synchronization/waitabl...
File base/synchronization/waitable_event.h (right):

http://codereview.chromium.org/8221021/diff/1001/base/synchronization/waitabl...
base/synchronization/waitable_event.h:77: // was signaled, else false is
returned to indicate that waiting failed.
Please update the comments.

[commit-bot: I haz the power, 2011-10-11 15:20:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/8221021/8001

[commit-bot: I haz the power, 2011-10-11 15:20:23]

Presubmit check for 8221021-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/in_process_webkit/indexed_db_key_utility_client.cc,chrome/browser/sync/glue/http_bridge.cc

Presubmit checks took 2.7s to calculate.

[Steve Block, 2011-10-11 15:27:16]

Adding hans and akalin for OWNERS

[hans, 2011-10-11 15:31:14]

On 2011/10/11 15:27:16, Steve Block wrote:
> Adding hans and akalin for OWNERS

LGTM for content/browser/in_process_webkit

[akalin, 2011-10-11 19:01:35]

On 2011/10/11 15:31:14, hans wrote:
> On 2011/10/11 15:27:16, Steve Block wrote:
> > Adding hans and akalin for OWNERS
> 
> LGTM for content/browser/in_process_webkit

sync LGTM

[commit-bot: I haz the power, 2011-10-12 00:09:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/8221021/8001

[commit-bot: I haz the power, 2011-10-12 00:23:29]

Try job failure for 8221021-8001 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-12 00:27:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/8221021/8001

[commit-bot: I haz the power, 2011-10-12 03:09:45]

Change committed as 104990