net/base/keygen_handler_unittest.cc - Issue 8221021: Modify WaitableEvent::Wait() to return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/keygen_handler_unittest.cc

Issue 8221021: Modify WaitableEvent::Wait() to return void (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed comment and style Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/keygen_handler_unittest.cc

diff --git a/net/base/keygen_handler_unittest.cc b/net/base/keygen_handler_unittest.cc

index f926311b8675fa67d62f53956f43b2e2a670336e..e10a160f8ca6f0ad712cd80ed52a1c73514653ab 100644

--- a/net/base/keygen_handler_unittest.cc

+++ b/net/base/keygen_handler_unittest.cc

@@ -133,8 +133,7 @@ TEST_F(KeygenHandlerTest, ConcurrencyTest) {

for (int i = 0; i < NUM_HANDLERS; i++) {

// Make sure the job completed

- bool signaled = events[i]->Wait();

- EXPECT_TRUE(signaled);

+ events[i]->Wait();

delete events[i];

events[i] = NULL;