base/synchronization/waitable_event_unittest.cc - Issue 8221021: Modify WaitableEvent::Wait() to return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/waitable_event_unittest.cc

Issue 8221021: Modify WaitableEvent::Wait() to return void (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed comment and style Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/synchronization/waitable_event_unittest.cc

diff --git a/base/synchronization/waitable_event_unittest.cc b/base/synchronization/waitable_event_unittest.cc

index 47e7ff7ada729d945f84f73792014ac35261dbc9..ad86d147039a1d19dbe3f880da53ad0750718395 100644

--- a/base/synchronization/waitable_event_unittest.cc

+++ b/base/synchronization/waitable_event_unittest.cc

@@ -23,7 +23,7 @@ TEST(WaitableEventTest, ManualBasics) {

EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10)));

event.Signal();

- EXPECT_TRUE(event.Wait());

+ event.Wait();

EXPECT_TRUE(event.TimedWait(TimeDelta::FromMilliseconds(10)));

}

@@ -41,7 +41,7 @@ TEST(WaitableEventTest, AutoBasics) {

EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10)));

event.Signal();

- EXPECT_TRUE(event.Wait());

+ event.Wait();

EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10)));

event.Signal();