chrome/browser/sync/glue/http_bridge.cc - Issue 8221021: Modify WaitableEvent::Wait() to return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/http_bridge.cc

Issue 8221021: Modify WaitableEvent::Wait() to return void (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed comment and style Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/http_bridge.cc

diff --git a/chrome/browser/sync/glue/http_bridge.cc b/chrome/browser/sync/glue/http_bridge.cc

index 51a10e8660a74063aef2986484c3d48a84f036b7..fb1d720120395c344579f6977f1cc34dc40f936c 100644

--- a/chrome/browser/sync/glue/http_bridge.cc

+++ b/chrome/browser/sync/glue/http_bridge.cc

@@ -198,9 +198,9 @@ bool HttpBridge::MakeSynchronousPost(int* error_code, int* response_code) {

return false;

}

- if (!http_post_completed_.Wait()) // Block until network request completes

- NOTREACHED(); // or is aborted. See OnURLFetchComplete

- // and Abort.

+ // Block until network request completes or is aborted. See

+ // OnURLFetchComplete and Abort.

+ http_post_completed_.Wait();

base::AutoLock lock(fetch_state_lock_);

DCHECK(fetch_state_.request_completed || fetch_state_.aborted);