Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: base/synchronization/waitable_event_unittest.cc

Issue 8221021: Modify WaitableEvent::Wait() to return void (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment and style Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/time.h" 5 #include "base/time.h"
6 #include "base/synchronization/waitable_event.h" 6 #include "base/synchronization/waitable_event.h"
7 #include "base/threading/platform_thread.h" 7 #include "base/threading/platform_thread.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 TEST(WaitableEventTest, ManualBasics) { 12 TEST(WaitableEventTest, ManualBasics) {
13 WaitableEvent event(true, false); 13 WaitableEvent event(true, false);
14 14
15 EXPECT_FALSE(event.IsSignaled()); 15 EXPECT_FALSE(event.IsSignaled());
16 16
17 event.Signal(); 17 event.Signal();
18 EXPECT_TRUE(event.IsSignaled()); 18 EXPECT_TRUE(event.IsSignaled());
19 EXPECT_TRUE(event.IsSignaled()); 19 EXPECT_TRUE(event.IsSignaled());
20 20
21 event.Reset(); 21 event.Reset();
22 EXPECT_FALSE(event.IsSignaled()); 22 EXPECT_FALSE(event.IsSignaled());
23 EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10))); 23 EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10)));
24 24
25 event.Signal(); 25 event.Signal();
26 EXPECT_TRUE(event.Wait()); 26 event.Wait();
27 EXPECT_TRUE(event.TimedWait(TimeDelta::FromMilliseconds(10))); 27 EXPECT_TRUE(event.TimedWait(TimeDelta::FromMilliseconds(10)));
28 } 28 }
29 29
30 TEST(WaitableEventTest, AutoBasics) { 30 TEST(WaitableEventTest, AutoBasics) {
31 WaitableEvent event(false, false); 31 WaitableEvent event(false, false);
32 32
33 EXPECT_FALSE(event.IsSignaled()); 33 EXPECT_FALSE(event.IsSignaled());
34 34
35 event.Signal(); 35 event.Signal();
36 EXPECT_TRUE(event.IsSignaled()); 36 EXPECT_TRUE(event.IsSignaled());
37 EXPECT_FALSE(event.IsSignaled()); 37 EXPECT_FALSE(event.IsSignaled());
38 38
39 event.Reset(); 39 event.Reset();
40 EXPECT_FALSE(event.IsSignaled()); 40 EXPECT_FALSE(event.IsSignaled());
41 EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10))); 41 EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10)));
42 42
43 event.Signal(); 43 event.Signal();
44 EXPECT_TRUE(event.Wait()); 44 event.Wait();
45 EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10))); 45 EXPECT_FALSE(event.TimedWait(TimeDelta::FromMilliseconds(10)));
46 46
47 event.Signal(); 47 event.Signal();
48 EXPECT_TRUE(event.TimedWait(TimeDelta::FromMilliseconds(10))); 48 EXPECT_TRUE(event.TimedWait(TimeDelta::FromMilliseconds(10)));
49 } 49 }
50 50
51 TEST(WaitableEventTest, WaitManyShortcut) { 51 TEST(WaitableEventTest, WaitManyShortcut) {
52 WaitableEvent* ev[5]; 52 WaitableEvent* ev[5];
53 for (unsigned i = 0; i < 5; ++i) 53 for (unsigned i = 0; i < 5; ++i)
54 ev[i] = new WaitableEvent(false, false); 54 ev[i] = new WaitableEvent(false, false);
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 EXPECT_EQ(WaitableEvent::WaitMany(ev, 5), 2u); 98 EXPECT_EQ(WaitableEvent::WaitMany(ev, 5), 2u);
99 99
100 PlatformThread::Join(thread); 100 PlatformThread::Join(thread);
101 101
102 for (unsigned i = 0; i < 5; ++i) 102 for (unsigned i = 0; i < 5; ++i)
103 delete ev[i]; 103 delete ev[i];
104 } 104 }
105 105
106 } // namespace base 106 } // namespace base
OLDNEW
« no previous file with comments | « base/synchronization/waitable_event_posix.cc ('k') | base/synchronization/waitable_event_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698