base/threading/worker_pool_unittest.cc - Issue 8221021: Modify WaitableEvent::Wait() to return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/worker_pool_unittest.cc

Issue 8221021: Modify WaitableEvent::Wait() to return void (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed comment and style Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/worker_pool_unittest.cc

diff --git a/base/threading/worker_pool_unittest.cc b/base/threading/worker_pool_unittest.cc

index 2d2b05574e2b17f8e14eb597c29ea434e9e8da14..bbdd8cf61ca779ff0026cc2b70f0c6cc8f322081 100644

--- a/base/threading/worker_pool_unittest.cc

+++ b/base/threading/worker_pool_unittest.cc

@@ -34,15 +34,12 @@ class PostTaskTestTask : public Task {

TEST_F(WorkerPoolTest, PostTask) {

WaitableEvent test_event(false, false);

WaitableEvent long_test_event(false, false);

- bool signaled;

WorkerPool::PostTask(FROM_HERE, new PostTaskTestTask(&test_event), false);

WorkerPool::PostTask(FROM_HERE, new PostTaskTestTask(&long_test_event), true);

- signaled = test_event.Wait();

- EXPECT_TRUE(signaled);

- signaled = long_test_event.Wait();

- EXPECT_TRUE(signaled);

+ test_event.Wait();

+ long_test_event.Wait();

}

} // namespace base