Modify WaitableEvent::Wait() to return void

chrome/service/gaia/service_gaia_authenticator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/gaia/service_gaia_authenticator.h"
 
 #include "base/message_loop_proxy.h"
 #include "chrome/service/net/service_url_request_context.h"
 #include "chrome/service/service_process.h"
 #include "googleurl/src/gurl.h"
@@ skipping 16 matching lines @@
                                     unsigned long* response_code,
                                     std::string* response_body) {
   DCHECK(url.SchemeIsSecure());
   DCHECK(io_message_loop_proxy_);
   io_message_loop_proxy_->PostTask(
       FROM_HERE,
       NewRunnableMethod(this, &ServiceGaiaAuthenticator::DoPost, url,
                         post_body));
   // TODO(sanjeevr): Waiting here until the network request completes is not
   // desirable. We need to change Post to be asynchronous.
-  if (!http_post_completed_.Wait())  // Block until network request completes.
-    NOTREACHED();                    // See OnURLFetchComplete.
+  // Block until network request completes. See OnURLFetchComplete.
+  http_post_completed_.Wait();
 
   *response_code = static_cast<int>(http_response_code_);
   *response_body = response_data_;
   return true;
 }
 
 // TODO(sanjeevr): This is a placeholder implementation. Need to move this logic
 // to a common location within the service process so that it can be resued by
 // other classes needing a backoff delay calculation.
 int ServiceGaiaAuthenticator::GetBackoffDelaySeconds(
@@ skipping 27 matching lines @@
   http_response_code_ = source->response_code();
   response_data_ = source->GetResponseStringRef();
   delete source;
   // Add an extra reference because we want http_post_completed_ to remain
   // valid until after Signal() returns.
   scoped_refptr<ServiceGaiaAuthenticator> keep_alive(this);
   // Wake the blocked thread in Post.
   http_post_completed_.Signal();
   // WARNING: DONT DO ANYTHING AFTER THIS CALL! |this| may be deleted!
 }