Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 7633060: Add option to not generate resources on bind in OpenGL ES (Closed)

Created:
9 years, 4 months ago by greggman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add option to not generate resources on bind in OpenGL ES This allowes us to more efficiently manage ids. It is not OpenGL ES 2.0 compatible though it probably fits most OpenGL ES programs. Note that we need to turn this off on Pepper and/or probably provide a way for Pepper to turn on on. I'm not sure of the path Pepper takes to setup. Assuming it goes through GraphicsContext3D then changes to webkit will be needed to get the flag all the way down through IPC to the GPU process. TEST=unit tests and ran a few pages in a chrome build BUG=92260 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96904

Patch Set 1 #

Patch Set 2 : nacl fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -150 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.cc View 4 chunks +5 lines, -1 line 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +2 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_demo.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 5 chunks +7 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 17 chunks +256 lines, -58 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 4 chunks +2 lines, -14 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 7 chunks +135 lines, -19 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 3 chunks +6 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +25 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 25 chunks +80 lines, -24 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/graphics_3d_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_context_3d_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, Ken and Antoine, could you take a look? Ken -> webkit/gpu Piman -> ...
9 years, 4 months ago (2011-08-15 08:37:29 UTC) #1
piman
LGTM for the pepper bits. If we want to wire it up, we can just ...
9 years, 4 months ago (2011-08-15 17:21:37 UTC) #2
apatrick_chromium
lgtm
9 years, 4 months ago (2011-08-15 19:43:48 UTC) #3
Ken Russell (switch to Gerrit)
9 years, 4 months ago (2011-08-15 19:46:47 UTC) #4
webkit/gpu LGTM

Powered by Google App Engine
This is Rietveld 408576698