Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: gpu/command_buffer/client/gles2_implementation.h

Issue 7633060: Add option to not generate resources on bind in OpenGL ES (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nacl fix Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gles2_demo.cc ('k') | gpu/command_buffer/client/gles2_implementation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gles2_implementation.h
diff --git a/gpu/command_buffer/client/gles2_implementation.h b/gpu/command_buffer/client/gles2_implementation.h
index 9ab625cca9cbab1c47bcf84083ae23c15a42c59b..057b046edcf0bfba0dcf16b7552cc4b2f6465e9d 100644
--- a/gpu/command_buffer/client/gles2_implementation.h
+++ b/gpu/command_buffer/client/gles2_implementation.h
@@ -87,7 +87,7 @@ class IdHandlerInterface {
virtual void MakeIds(GLuint id_offset, GLsizei n, GLuint* ids) = 0;
// Frees some ids.
- virtual void FreeIds(GLsizei n, const GLuint* ids) = 0;
+ virtual bool FreeIds(GLsizei n, const GLuint* ids) = 0;
// Marks an id as used for glBind functions. id = 0 does nothing.
virtual bool MarkAsUsedForBind(GLuint id) = 0;
@@ -156,7 +156,8 @@ class GLES2Implementation {
size_t transfer_buffer_size,
void* transfer_buffer,
int32 transfer_buffer_id,
- bool share_resources);
+ bool share_resources,
+ bool bind_generates_resource = true); // Will remove in 2 CLs!
~GLES2Implementation();
@@ -177,7 +178,6 @@ class GLES2Implementation {
void GetVertexAttribiv(GLuint index, GLenum pname, GLint* params);
void GetProgramInfoCHROMIUMHelper(GLuint program, std::vector<int8>* result);
- void DeleteProgramOrShaderHelper(GLuint program_or_shader);
GLint GetAttribLocationHelper(GLuint program, const char* name);
GLint GetUniformLocationHelper(GLuint program, const char* name);
bool GetActiveAttribHelper(
@@ -383,6 +383,8 @@ class GLES2Implementation {
void DeleteFramebuffersHelper(GLsizei n, const GLuint* framebuffers);
void DeleteRenderbuffersHelper(GLsizei n, const GLuint* renderbuffers);
void DeleteTexturesHelper(GLsizei n, const GLuint* textures);
+ bool DeleteProgramHelper(GLuint program);
+ bool DeleteShaderHelper(GLuint shader);
// Helper for GetVertexAttrib
bool GetVertexAttribHelper(GLuint index, GLenum pname, uint32* param);
@@ -474,6 +476,8 @@ class GLES2Implementation {
// Whether or not this context is sharing resources.
bool sharing_resources_;
+ bool bind_generates_resource_;
+
// Map of GLenum to Strings for glGetString. We need to cache these because
// the pointer passed back to the client has to remain valid for eternity.
typedef std::map<uint32, std::set<std::string> > GLStringMap;
« no previous file with comments | « gpu/command_buffer/client/gles2_demo.cc ('k') | gpu/command_buffer/client/gles2_implementation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698