Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed)

Created:
9 years, 4 months ago by brettw

Modified:
9 years, 4 months ago

Reviewers:
polina

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't use a scoped_refptr for StringVar::FromPPVar This was leftover from a previous design where I thought it would be necessary. It turns out it just made the code ugly and did unnecessary refcounting. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97751

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -50 lines)			Patch
M	ppapi/proxy/plugin_var_serialization_rules.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_font_proxy.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_url_util_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_var_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppp_messaging_proxy_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/shared_impl/url_util_impl.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	ppapi/shared_impl/var.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/shared_impl/var.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/message_channel.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/npapi_glue.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_clipboard_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_font_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_transport_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_uma_private_impl.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_request_info_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_util_impl.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_var_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_creation_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/08/17 20:45:12, brettw wrote:

LGTM

Expand Messages | Collapse Messages