ppapi/proxy/ppb_var_deprecated_proxy.cc - Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_var_deprecated_proxy.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/ppb_var_deprecated_proxy.cc

diff --git a/ppapi/proxy/ppb_var_deprecated_proxy.cc b/ppapi/proxy/ppb_var_deprecated_proxy.cc

index ff32df15773973fabd1ff8c4fbda360afc08746a..396e50e0024d739e65b31fc35c2b8a9449016366 100644

--- a/ppapi/proxy/ppb_var_deprecated_proxy.cc

+++ b/ppapi/proxy/ppb_var_deprecated_proxy.cc

@@ -70,7 +70,7 @@ PP_Var VarFromUtf8(PP_Module module, const char* data, uint32_t len) {

}

const char* VarToUtf8(PP_Var var, uint32_t* len) {

- scoped_refptr<StringVar> str(StringVar::FromPPVar(var));

+ StringVar* str = StringVar::FromPPVar(var);

if (str) {

*len = static_cast<uint32_t>(str->value().size());

return str->value().c_str();

« no previous file with comments | « ppapi/proxy/ppb_url_util_proxy.cc ('k') | ppapi/proxy/ppb_var_proxy.cc » ('j') | no next file with comments »