ppapi/proxy/resource_creation_proxy.cc - Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/resource_creation_proxy.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/resource_creation_proxy.cc

diff --git a/ppapi/proxy/resource_creation_proxy.cc b/ppapi/proxy/resource_creation_proxy.cc

index bc9d0e872cd1e9590f8666087fe7ed8819d7c60f..c6d02a7e5d2bc55f1c82edd8bf8c8bf23497bc79 100644

--- a/ppapi/proxy/resource_creation_proxy.cc

+++ b/ppapi/proxy/resource_creation_proxy.cc

@@ -211,7 +211,7 @@ PP_Resource ResourceCreationProxy::CreateKeyboardInputEvent(

data.event_modifiers = modifiers;

data.key_code = key_code;

if (character_text.type == PP_VARTYPE_STRING) {

- scoped_refptr<StringVar> text_str(StringVar::FromPPVar(character_text));

+ StringVar* text_str = StringVar::FromPPVar(character_text);

if (!text_str)

return 0;

data.character_text = text_str->value();

« no previous file with comments | « ppapi/proxy/ppp_messaging_proxy_test.cc ('k') | ppapi/shared_impl/url_util_impl.cc » ('j') | no next file with comments »