Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ppapi/proxy/plugin_var_serialization_rules.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/proxy/ppb_font_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_var_serialization_rules.cc
diff --git a/ppapi/proxy/plugin_var_serialization_rules.cc b/ppapi/proxy/plugin_var_serialization_rules.cc
index f5147737a00697f56f509de6e76a8cebf2e1dfb6..49e1fc31289a09bba51b07217ca301275b34b03a 100644
--- a/ppapi/proxy/plugin_var_serialization_rules.cc
+++ b/ppapi/proxy/plugin_var_serialization_rules.cc
@@ -28,8 +28,8 @@ PP_Var PluginVarSerializationRules::SendCallerOwned(const PP_Var& var,
// Retrieve the string to use for IPC.
if (var.type == PP_VARTYPE_STRING) {
- scoped_refptr<StringVar> string_var(StringVar::FromPPVar(var));
- if (string_var.get())
+ StringVar* string_var = StringVar::FromPPVar(var);
+ if (string_var)
*str_val = string_var->value();
else
NOTREACHED() << "Trying to send unknown string over IPC.";
@@ -116,8 +116,8 @@ PP_Var PluginVarSerializationRules::BeginSendPassRef(const PP_Var& var,
return var_tracker_->GetHostObject(var);
if (var.type == PP_VARTYPE_STRING) {
- scoped_refptr<StringVar> string_var(StringVar::FromPPVar(var));
- if (string_var.get())
+ StringVar* string_var = StringVar::FromPPVar(var);
+ if (string_var)
*str_val = string_var->value();
else
NOTREACHED() << "Trying to send unknown string over IPC.";
« no previous file with comments | « no previous file | ppapi/proxy/ppb_font_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698