Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: ppapi/proxy/ppb_font_proxy.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/plugin_var_serialization_rules.cc ('k') | ppapi/proxy/ppb_url_util_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_font_proxy.cc
diff --git a/ppapi/proxy/ppb_font_proxy.cc b/ppapi/proxy/ppb_font_proxy.cc
index 987c918e2edf15026cdb01be381f5af0d0dbd7f9..3c42ecd30df7215ef3fa691249bf36581f3b5bfe 100644
--- a/ppapi/proxy/ppb_font_proxy.cc
+++ b/ppapi/proxy/ppb_font_proxy.cc
@@ -30,7 +30,7 @@ namespace {
bool PPTextRunToTextRun(const PP_TextRun_Dev* run,
WebKitForwarding::Font::TextRun* output) {
- scoped_refptr<StringVar> str(StringVar::FromPPVar(run->text));
+ StringVar* str = StringVar::FromPPVar(run->text);
if (!str)
return false;
@@ -97,7 +97,7 @@ Font::Font(const HostResource& resource,
: Resource(resource),
webkit_event_(false, false) {
TRACE_EVENT0("ppapi proxy", "Font::Font");
- scoped_refptr<StringVar> face(StringVar::FromPPVar(desc.face));
+ StringVar* face = StringVar::FromPPVar(desc.face);
PluginDispatcher* dispatcher = PluginDispatcher::GetForResource(this);
WebKitForwarding* forwarding = dispatcher->GetWebKitForwarding();
@@ -106,7 +106,7 @@ Font::Font(const HostResource& resource,
base::Bind(&WebKitForwarding::CreateFontForwarding,
base::Unretained(forwarding),
&webkit_event_, desc,
- face.get() ? face->value() : std::string(),
+ face ? face->value() : std::string(),
dispatcher->preferences(),
&font_forwarding_));
}
« no previous file with comments | « ppapi/proxy/plugin_var_serialization_rules.cc ('k') | ppapi/proxy/ppb_url_util_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698