ppapi/proxy/ppp_messaging_proxy_test.cc - Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppp_messaging_proxy_test.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/ppp_messaging_proxy_test.cc

diff --git a/ppapi/proxy/ppp_messaging_proxy_test.cc b/ppapi/proxy/ppp_messaging_proxy_test.cc

index 839a7efb1077014ee5da13594a55e8844a9aa1fa..4d02ae2bdb731c6f51232bdb8d299bb50b767319 100644

--- a/ppapi/proxy/ppp_messaging_proxy_test.cc

+++ b/ppapi/proxy/ppp_messaging_proxy_test.cc

@@ -128,7 +128,7 @@ TEST_F(PPP_Messaging_ProxyTest, SendMessages) {

EXPECT_EQ(expected_instance, received_instance);

EXPECT_EQ(expected_var.type, received_var.type);

- scoped_refptr<StringVar> received_string(StringVar::FromPPVar(received_var));

+ StringVar* received_string = StringVar::FromPPVar(received_var);

ASSERT_TRUE(received_string.get());

EXPECT_EQ(kTestString, received_string->value());

// Now release the var, and the string should go away (because the ref

« no previous file with comments | « ppapi/proxy/ppb_var_proxy.cc ('k') | ppapi/proxy/resource_creation_proxy.cc » ('j') | no next file with comments »