Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: webkit/plugins/ppapi/ppb_uma_private_impl.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppb_transport_impl.cc ('k') | webkit/plugins/ppapi/ppb_url_request_info_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_uma_private_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_uma_private_impl.cc b/webkit/plugins/ppapi/ppb_uma_private_impl.cc
index 10807cb38f072b6274e750c3e7144c7caa0180ee..ec85c16309c40c7e200378b19b1fe0733ccfa39a 100644
--- a/webkit/plugins/ppapi/ppb_uma_private_impl.cc
+++ b/webkit/plugins/ppapi/ppb_uma_private_impl.cc
@@ -33,7 +33,7 @@ void HistogramCustomTimes(PP_Var name,
uint32_t bucket_count) {
RETURN_IF_BAD_ARGS(name, sample, min, max, bucket_count);
- scoped_refptr<StringVar> name_string(StringVar::FromPPVar(name));
+ StringVar* name_string = StringVar::FromPPVar(name);
if (name_string == NULL)
return;
base::Histogram* counter =
@@ -52,7 +52,7 @@ void HistogramCustomCounts(PP_Var name,
uint32_t bucket_count) {
RETURN_IF_BAD_ARGS(name, sample, min, max, bucket_count);
- scoped_refptr<StringVar> name_string(StringVar::FromPPVar(name));
+ StringVar* name_string = StringVar::FromPPVar(name);
if (name_string == NULL)
return;
base::Histogram* counter =
@@ -70,7 +70,7 @@ void HistogramEnumeration(PP_Var name,
int32_t boundary_value) {
RETURN_IF_BAD_ARGS(name, sample, 1, boundary_value, boundary_value + 1);
- scoped_refptr<StringVar> name_string(StringVar::FromPPVar(name));
+ StringVar* name_string = StringVar::FromPPVar(name);
if (name_string == NULL)
return;
base::Histogram* counter =
« no previous file with comments | « webkit/plugins/ppapi/ppb_transport_impl.cc ('k') | webkit/plugins/ppapi/ppb_url_request_info_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698