webkit/plugins/ppapi/ppb_url_request_info_impl.cc - Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_url_request_info_impl.cc

Issue 7621054: Don't use a scoped_refptr for StringVar::FromPPVar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_url_request_info_impl.cc

diff --git a/webkit/plugins/ppapi/ppb_url_request_info_impl.cc b/webkit/plugins/ppapi/ppb_url_request_info_impl.cc

index 8820a41bf3ba3be31d713a041f09fabc47916725..1b72319116f0e721e0b51d2f89df2d2310a66fc0 100644

--- a/webkit/plugins/ppapi/ppb_url_request_info_impl.cc

+++ b/webkit/plugins/ppapi/ppb_url_request_info_impl.cc

@@ -220,7 +220,7 @@ PP_Bool PPB_URLRequestInfo_Impl::SetProperty(PP_URLRequestProperty property,

SetIntegerProperty(property, var.value.as_int));

break;

case PP_VARTYPE_STRING: {

- scoped_refptr<StringVar> string(StringVar::FromPPVar(var));

+ StringVar* string = StringVar::FromPPVar(var);

if (string)

result = PP_FromBool(SetStringProperty(property, string->value()));

break;