Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6722026: Refactor: Move app/gfx/gl ==> ui/gfx/gl (Closed)

Created:
9 years, 9 months ago by jonathan.backer
Modified:
9 years, 7 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., jam, apatrick_chromium, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Refactor: Move app/gfx/gl ==> ui/gfx/gl This is the final patch in the sequence. Note that gl.gyp is introduced because dependency checking on the Mac is done on a per file (rather than per target) basis. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79599

Patch Set 1 : Merge with trunk. #

Patch Set 2 : Try removing a dep. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -272 lines) Patch
M app/app_base.gypi View 1 7 chunks +0 lines, -89 lines 0 comments Download
M chrome/browser/gpu_data_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gpu_process_host_ui_shim.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages_params.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/test/gpu/gpu_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_crash.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/sandbox_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_info_collector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/gpu_info_collector_mac.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_info_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_render_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/media/fake_gl_video_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_demo.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gl_mock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/unittest_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_processor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/demos/framework/main_exe.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 3 chunks +4 lines, -3 lines 0 comments Download
M media/media.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M media/tools/player_x11/gl_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/gl_video_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/tools/shader_bench/gpu_color_painter.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/shader_bench/gpu_color_painter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/tools/shader_bench/gpu_color_painter_exp.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/shader_bench/gpu_painter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/tools/shader_bench/shader_bench.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/tools/tile_render_bench/tile_render_bench.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/compositor_gl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/generate_bindings.py View 6 chunks +10 lines, -10 lines 0 comments Download
A ui/gfx/gl/gl.gyp View 1 1 chunk +160 lines, -0 lines 0 comments Download
A + ui/gfx/gl/gl_bindings.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/gl/gl_bindings_skia.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/gl/gl_bindings_skia.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/gl_context.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/gl/gl_context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/gl_context_egl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/gl/gl_context_egl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/gl/gl_context_linux.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/gl/gl_context_mac.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + ui/gfx/gl/gl_context_osmesa.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/gl/gl_context_osmesa.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/gl_context_stub.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/gl/gl_context_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/gl/gl_context_win.cc View 1 chunk +6 lines, -7 lines 0 comments Download
A + ui/gfx/gl/gl_implementation.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/gl/gl_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/gl/gl_implementation_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/gl_implementation_mac.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/gl_implementation_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gl/gl_interface.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/gl/gl_interface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/surface/accelerated_surface_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/surface/surface.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_gfx.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/gpu/webkit_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/test_webkit_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jonathan.backer
This is close to final form. I had previous versions pass the trybots. I'm just ...
9 years, 9 months ago (2011-03-28 17:00:44 UTC) #1
Ben Goodger (Google)
9 years, 9 months ago (2011-03-28 17:08:13 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698