Clang: enable -Wbool-conversions and -Wunused-variables on Linux.

Clang: enable -Wbool-conversions and -Wunused-variables on Linux.

-Wbool-conversion warns about EXPECT_EQ(false, blah), so replace
that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah)
for good measure (even though that doesn't generate warnings).

Also remove the one instance of an unused variable.

BUG=69421
TEST=buildbots all compile and all tests pass

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71431

[Nico, 2011-01-13 16:44:30]

LG

I was wondering why this touches shared files, since the mac bot should've
caught these already. The explanation is that in most of the shared files, only
the TRUE case was present, which isn't an error. And we don't build o3d on mac.
Sot it's all good.

http://codereview.chromium.org/6300001/diff/2001/base/message_loop_unittest.cc
File base/message_loop_unittest.cc (right):

http://codereview.chromium.org/6300001/diff/2001/base/message_loop_unittest.c...
base/message_loop_unittest.cc:1558:
EXPECT_FALSE(loop.high_resolution_timers_enabled());
This is in an OS_WIN block…I assume you just mass-replaced all over the project?

http://codereview.chromium.org/6300001/diff/2001/net/base/cert_database_nss_u...
File net/base/cert_database_nss_unittest.cc (right):

http://codereview.chromium.org/6300001/diff/2001/net/base/cert_database_nss_u...
net/base/cert_database_nss_unittest.cc:326: certs, CertDatabase::TRUSTED_SSL |
CertDatabase::TRUSTED_EMAIL,
revert indentation change

http://codereview.chromium.org/6300001/diff/2001/net/base/cert_database_nss_u...
net/base/cert_database_nss_unittest.cc:341: certs, CertDatabase::TRUSTED_SSL |
CertDatabase::TRUSTED_EMAIL,
here too

http://codereview.chromium.org/6300001/diff/2001/net/base/cert_database_nss_u...
net/base/cert_database_nss_unittest.cc:385: certs, CertDatabase::TRUSTED_SSL |
CertDatabase::TRUSTED_EMAIL,
here too

http://codereview.chromium.org/6300001/diff/2001/net/base/cert_database_nss_u...
net/base/cert_database_nss_unittest.cc:409: certs, CertDatabase::TRUSTED_SSL |
CertDatabase::TRUSTED_EMAIL |
here too

http://codereview.chromium.org/6300001/diff/2001/net/base/cert_database_nss_u...
net/base/cert_database_nss_unittest.cc:485: EXPECT_TRUE(cert_db_.SetCertTrust(
here too