Clang: enable -Wbool-conversions and -Wunused-variables on Linux.

ceee/ie/broker/cookie_api_module_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Cookie API implementation unit tests.
 
 // MockWin32 can't be included after ChromeFrameHost because of an include
 // incompatibility with atlwin.h.
 #include "ceee/testing/utils/mock_win32.h"  // NOLINT
 
@@ skipping 938 matching lines @@
               PostError(StrEq("Not implemented."))).Times(1);
   invocation.Execute(args, kRequestId);
 }
 
 TEST_F(CookieApiTests, CookieChangedEventHandler) {
   testing::LogDisabler no_dchecks;
   MockCookieChanged cookie_changed;
   std::string converted_args;
   // Empty args.
   std::string input_args = "";
-  EXPECT_EQ(false,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_FALSE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
   // Invalid args.
   input_args = "[false, {hello]";
-  EXPECT_EQ(false,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_FALSE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
   input_args = "[3]";
-  EXPECT_EQ(false,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_FALSE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
   // Valid args.
   input_args = "[{\"removed\": false, \"cookie\": {\"storeId\": \"1\"}}]";
 
   // Invalid store ID.
   cookie_changed.AllocateApiResult();
   EXPECT_CALL(*cookie_changed.api_result_,
               GetAnyWindowInStore(StrEq("1"), true, _, _))
       .WillOnce(Return(false));
-  EXPECT_EQ(false,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_FALSE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
 
   // Cookie store access errors.
   cookie_changed.AllocateApiResult();
   EXPECT_CALL(*cookie_changed.api_result_,
               GetAnyWindowInStore(StrEq("1"), true, _, _))
       .WillOnce(DoAll(SetArgumentPointee<2>(HWND(5)),
                       SetArgumentPointee<3>(false),
                       Return(true)));
   EXPECT_CALL(*cookie_changed.api_result_,
               CookieStoreIsRegistered(HWND(5))).WillOnce(Return(E_FAIL));
-  EXPECT_EQ(false,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_FALSE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
 
   cookie_changed.AllocateApiResult();
   EXPECT_CALL(*cookie_changed.api_result_,
               GetAnyWindowInStore(StrEq("1"), true, _, _))
       .WillOnce(DoAll(SetArgumentPointee<2>(HWND(5)),
                       SetArgumentPointee<3>(false),
                       Return(true)));
   EXPECT_CALL(*cookie_changed.api_result_,
               CookieStoreIsRegistered(HWND(5))).WillOnce(Return(S_FALSE));
   EXPECT_CALL(*cookie_changed.api_result_,
               RegisterCookieStore(HWND(5))).WillOnce(Return(E_FAIL));
-  EXPECT_EQ(false,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_FALSE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
 
   // Registered cookie store.
   cookie_changed.AllocateApiResult();
   EXPECT_CALL(*cookie_changed.api_result_,
               GetAnyWindowInStore(StrEq("1"), true, _, _))
       .WillOnce(DoAll(SetArgumentPointee<2>(HWND(5)),
                       SetArgumentPointee<3>(false),
                       Return(true)));
   EXPECT_CALL(*cookie_changed.api_result_,
               CookieStoreIsRegistered(HWND(5))).WillOnce(Return(S_OK));
-  EXPECT_EQ(true,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_TRUE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
 
   // Unregistered cookie store.
   cookie_changed.AllocateApiResult();
   EXPECT_CALL(*cookie_changed.api_result_,
               GetAnyWindowInStore(StrEq("1"), true, _, _))
       .WillOnce(DoAll(SetArgumentPointee<2>(HWND(5)),
                       SetArgumentPointee<3>(false),
                       Return(true)));
   EXPECT_CALL(*cookie_changed.api_result_,
               CookieStoreIsRegistered(HWND(5))).WillOnce(Return(S_FALSE));
   EXPECT_CALL(*cookie_changed.api_result_,
               RegisterCookieStore(HWND(5))).WillOnce(Return(S_OK));
-  EXPECT_EQ(true,
-            cookie_changed.EventHandlerImpl(input_args, &converted_args));
+  EXPECT_TRUE(cookie_changed.EventHandlerImpl(input_args, &converted_args));
 }
 
 }  // namespace