chrome/browser/tab_contents/navigation_controller_unittest.cc - Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/navigation_controller_unittest.cc

Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, undo indent Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/navigation_controller_unittest.cc

diff --git a/chrome/browser/tab_contents/navigation_controller_unittest.cc b/chrome/browser/tab_contents/navigation_controller_unittest.cc

index 1935457e58a6e5476b28f71ea40694204fa27dcb..ca337a7494edefc37148de5fc588cf982bcef3dd 100644

--- a/chrome/browser/tab_contents/navigation_controller_unittest.cc

+++ b/chrome/browser/tab_contents/navigation_controller_unittest.cc

@@ -1641,7 +1641,7 @@ TEST_F(NavigationControllerTest, ViewSourceRedirect) {

controller().RendererDidNavigate(params, 0, &details);

EXPECT_EQ(ASCIIToUTF16(kExpected), contents()->GetTitle());

- EXPECT_EQ(true, contents()->ShouldDisplayURL());

+ EXPECT_TRUE(contents()->ShouldDisplayURL());

}

// Make sure that on cloning a tabcontents and going back needs_reload is false.