Clang: enable -Wbool-conversions and -Wunused-variables on Linux.

views/view_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "gfx/canvas_skia.h"
 #include "gfx/path.h"
@@ skipping 758 matching lines @@
   HitTestView* v2 = new HitTestView(true);
   v2->SetBounds(v2_bounds);
   root_view->AddChildView(v2);
 
   gfx::Point v1_centerpoint = v1_bounds.CenterPoint();
   gfx::Point v2_centerpoint = v2_bounds.CenterPoint();
   gfx::Point v1_origin = v1_bounds.origin();
   gfx::Point v2_origin = v2_bounds.origin();
 
   // Test HitTest
-  EXPECT_EQ(true, v1->HitTest(ConvertPointToView(v1, v1_centerpoint)));
-  EXPECT_EQ(true, v2->HitTest(ConvertPointToView(v2, v2_centerpoint)));
+  EXPECT_TRUE(v1->HitTest(ConvertPointToView(v1, v1_centerpoint)));
+  EXPECT_TRUE(v2->HitTest(ConvertPointToView(v2, v2_centerpoint)));
 
-  EXPECT_EQ(true, v1->HitTest(ConvertPointToView(v1, v1_origin)));
-  EXPECT_EQ(false, v2->HitTest(ConvertPointToView(v2, v2_origin)));
+  EXPECT_TRUE(v1->HitTest(ConvertPointToView(v1, v1_origin)));
+  EXPECT_FALSE(v2->HitTest(ConvertPointToView(v2, v2_origin)));
 
   // Test GetViewForPoint
   EXPECT_EQ(v1, root_view->GetViewForPoint(v1_centerpoint));
   EXPECT_EQ(v2, root_view->GetViewForPoint(v2_centerpoint));
   EXPECT_EQ(v1, root_view->GetViewForPoint(v1_origin));
   EXPECT_EQ(root_view, root_view->GetViewForPoint(v2_origin));
 }
 
 TEST_F(ViewTest, Textfield) {
   const string16 kText = ASCIIToUTF16("Reality is that which, when you stop "
@@ skipping 673 matching lines @@
 #endif
 }
 
 TEST_F(ViewTest, ChangeNativeViewHierarchyChangeHierarchy) {
   // TODO(georgey): Fix the test for Linux
 #if defined(OS_WIN)
   TestChangeNativeViewHierarchy test(this);
   test.CheckChangingHierarhy();
 #endif
 }