webkit/glue/cpp_variant_unittest.cc - Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/cpp_variant_unittest.cc

Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, undo indent Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/glue/cpp_variant_unittest.cc

diff --git a/webkit/glue/cpp_variant_unittest.cc b/webkit/glue/cpp_variant_unittest.cc

index 43c78de718c26c5f9198c54b2acdc64a487daecf..6609416a0feb85f3d5fe940cc24f79404f0006db 100644

--- a/webkit/glue/cpp_variant_unittest.cc

+++ b/webkit/glue/cpp_variant_unittest.cc

@@ -273,7 +273,7 @@ TEST(CppVariantTest, SetsSimpleTypesAndValues) {

CppVariant cpp;

cpp.Set(true);

EXPECT_EQ(NPVariantType_Bool, cpp.type);

- EXPECT_EQ(true, cpp.value.boolValue);

+ EXPECT_TRUE(cpp.value.boolValue);

cpp.Set(5);

EXPECT_EQ(NPVariantType_Int32, cpp.type);

« no previous file with comments | « views/view_unittest.cc ('k') | webkit/plugins/npapi/webplugin_impl_unittest.cc » ('j') | no next file with comments »