Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: webkit/plugins/npapi/webplugin_impl_unittest.cc

Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, undo indent Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/cpp_variant_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/webplugin_impl_unittest.cc
diff --git a/webkit/plugins/npapi/webplugin_impl_unittest.cc b/webkit/plugins/npapi/webplugin_impl_unittest.cc
index 45d4ddc91b20e2a211c9d663aa89d161d4b0da71..edb35ddf9b33e2055b086373d82863dfdc5df720 100644
--- a/webkit/plugins/npapi/webplugin_impl_unittest.cc
+++ b/webkit/plugins/npapi/webplugin_impl_unittest.cc
@@ -58,7 +58,7 @@ TEST(WebPluginImplTest, PostParserSimple) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("bar", GetHeader(request, "foo"));
EXPECT_EQ(0U, GetHeader(request, "bar").length());
EXPECT_EQ(0U, GetHeader(request, "Content-length").length());
@@ -72,7 +72,7 @@ TEST(WebPluginImplTest, PostParserLongHeader) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ(100U, GetHeader(request, "foo").length());
}
@@ -83,7 +83,7 @@ TEST(WebPluginImplTest, PostParserManyHeaders) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("h1", GetHeader(request, "h1"));
EXPECT_EQ("h2", GetHeader(request, "h2"));
EXPECT_EQ("h3", GetHeader(request, "h3"));
@@ -106,7 +106,7 @@ TEST(WebPluginImplTest, PostParserDuplicateHeaders) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
}
TEST(WebPluginImplTest, PostParserNoHeaders) {
@@ -116,7 +116,7 @@ TEST(WebPluginImplTest, PostParserNoHeaders) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ(0U, GetHeader(request, "foo").length());
EXPECT_EQ(0U, GetHeader(request, "bar").length());
EXPECT_EQ(0U, GetHeader(request, "Content-length").length());
@@ -130,7 +130,7 @@ TEST(WebPluginImplTest, PostParserNoBody) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("bar", GetHeader(request, "foo"));
EXPECT_EQ(0U, GetHeader(request, "bar").length());
EXPECT_EQ(0U, GetHeader(request, "Content-length").length());
@@ -144,7 +144,7 @@ TEST(WebPluginImplTest, PostParserBodyWithNewLines) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ(GetBodyText(request), "\n\nabcdefg\n\nabcdefg");
}
@@ -155,7 +155,7 @@ TEST(WebPluginImplTest, PostParserErrorNoBody) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
}
TEST(WebPluginImplTest, PostParserErrorEmpty) {
@@ -165,7 +165,7 @@ TEST(WebPluginImplTest, PostParserErrorEmpty) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
}
TEST(WebPluginImplTest, PostParserEmptyName) {
@@ -175,7 +175,7 @@ TEST(WebPluginImplTest, PostParserEmptyName) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("bar", GetHeader(request, "foo"));
EXPECT_EQ("body", GetBodyText(request));
}
@@ -187,7 +187,7 @@ TEST(WebPluginImplTest, PostParserEmptyValue) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("bar", GetHeader(request, "foo"));
EXPECT_EQ(0U, GetHeader(request, "bar").length());
EXPECT_EQ("body", GetBodyText(request));
@@ -200,7 +200,7 @@ TEST(WebPluginImplTest, PostParserCRLF) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
static_cast<uint32>(strlen(ex1)));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("bar", GetHeader(request, "foo"));
EXPECT_EQ(0U, GetHeader(request, "bar").length());
EXPECT_EQ("body\r\n\r\nbody2", GetBodyText(request));
@@ -217,7 +217,7 @@ TEST(WebPluginImplTest, PostParserBodyWithBinaryData) {
request.initialize();
bool rv = WebPluginImpl::SetPostData(&request, ex1,
sizeof(ex1)/sizeof(ex1[0]));
- EXPECT_EQ(true, rv);
+ EXPECT_TRUE(rv);
EXPECT_EQ("bar", GetHeader(request, "foo"));
EXPECT_EQ(0U, GetHeader(request, "bar").length());
EXPECT_EQ(0U, GetHeader(request, "Content-length").length());
« no previous file with comments | « webkit/glue/cpp_variant_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698