Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: net/websockets/websocket_job_unittest.cc

Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, undo indent Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ssl_config_service_win_unittest.cc ('k') | o3d/utils/cross/file_text_reader_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/websockets/websocket_job_unittest.cc
diff --git a/net/websockets/websocket_job_unittest.cc b/net/websockets/websocket_job_unittest.cc
index 43d8509706bcde44a8ea3421ba1f48039913b975..342a2a3b653a9e1d5c8b6248f14460520a3a4394 100644
--- a/net/websockets/websocket_job_unittest.cc
+++ b/net/websockets/websocket_job_unittest.cc
@@ -263,7 +263,7 @@ TEST_F(WebSocketJobTest, SimpleHandshake) {
bool sent = websocket_->SendData(kHandshakeRequestMessage,
strlen(kHandshakeRequestMessage));
- EXPECT_EQ(true, sent);
+ EXPECT_TRUE(sent);
MessageLoop::current()->RunAllPending();
EXPECT_EQ(kHandshakeRequestMessage, socket_->sent_data());
EXPECT_EQ(WebSocketJob::CONNECTING, GetWebSocketJobState());
@@ -308,7 +308,7 @@ TEST_F(WebSocketJobTest, SlowHandshake) {
bool sent = websocket_->SendData(kHandshakeRequestMessage,
strlen(kHandshakeRequestMessage));
- EXPECT_EQ(true, sent);
+ EXPECT_TRUE(sent);
// We assume request is sent in one data chunk (from WebKit)
// We don't support streaming request.
MessageLoop::current()->RunAllPending();
@@ -390,7 +390,7 @@ TEST_F(WebSocketJobTest, HandshakeWithCookie) {
bool sent = websocket_->SendData(kHandshakeRequestMessage,
strlen(kHandshakeRequestMessage));
- EXPECT_EQ(true, sent);
+ EXPECT_TRUE(sent);
MessageLoop::current()->RunAllPending();
EXPECT_EQ(kHandshakeRequestExpected, socket_->sent_data());
EXPECT_EQ(WebSocketJob::CONNECTING, GetWebSocketJobState());
@@ -477,7 +477,7 @@ TEST_F(WebSocketJobTest, HandshakeWithCookieButNotAllowed) {
bool sent = websocket_->SendData(kHandshakeRequestMessage,
strlen(kHandshakeRequestMessage));
- EXPECT_EQ(true, sent);
+ EXPECT_TRUE(sent);
MessageLoop::current()->RunAllPending();
EXPECT_EQ(kHandshakeRequestExpected, socket_->sent_data());
EXPECT_EQ(WebSocketJob::CONNECTING, GetWebSocketJobState());
« no previous file with comments | « net/base/ssl_config_service_win_unittest.cc ('k') | o3d/utils/cross/file_text_reader_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698