Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: build/common.gypi

Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, undo indent Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/pr_time_unittest.cc ('k') | ceee/ie/broker/cookie_api_module_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 'cflags': [ 1129 'cflags': [
1130 '--sysroot=<(sysroot)', 1130 '--sysroot=<(sysroot)',
1131 ], 1131 ],
1132 'ldflags': [ 1132 'ldflags': [
1133 '--sysroot=<(sysroot)', 1133 '--sysroot=<(sysroot)',
1134 ], 1134 ],
1135 }]] 1135 }]]
1136 }], 1136 }],
1137 ['clang==1', { 1137 ['clang==1', {
1138 'cflags': [ 1138 'cflags': [
1139 # Don't warn about unused variables, due to a common pattern:
1140 # scoped_deleter unused_variable(&thing_to_delete);
1141 '-Wno-unused-variable',
1142 # Clang spots more unused functions. 1139 # Clang spots more unused functions.
1143 '-Wno-unused-function', 1140 '-Wno-unused-function',
1144 # gtest confuses clang.
1145 '-Wno-bool-conversions',
1146 # Don't die on dtoa code that uses a char as an array index. 1141 # Don't die on dtoa code that uses a char as an array index.
1147 '-Wno-char-subscripts', 1142 '-Wno-char-subscripts',
1148 # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see 1143 # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
1149 # http://code.google.com/p/googletest/source/detail?r=446 . 1144 # http://code.google.com/p/googletest/source/detail?r=446 .
1150 # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ). 1145 # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ).
1151 '-Wno-unnamed-type-template-args', 1146 '-Wno-unnamed-type-template-args',
1152 ], 1147 ],
1153 'cflags!': [ 1148 'cflags!': [
1154 # Clang doesn't seem to know know this flag. 1149 # Clang doesn't seem to know know this flag.
1155 '-mfpmath=sse', 1150 '-mfpmath=sse',
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
1509 # and therefore SYMROOT, needs to be set at the project level. 1504 # and therefore SYMROOT, needs to be set at the project level.
1510 'SYMROOT': '<(DEPTH)/xcodebuild', 1505 'SYMROOT': '<(DEPTH)/xcodebuild',
1511 }, 1506 },
1512 } 1507 }
1513 1508
1514 # Local Variables: 1509 # Local Variables:
1515 # tab-width:2 1510 # tab-width:2
1516 # indent-tabs-mode:nil 1511 # indent-tabs-mode:nil
1517 # End: 1512 # End:
1518 # vim: set expandtab tabstop=2 shiftwidth=2: 1513 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « base/pr_time_unittest.cc ('k') | ceee/ie/broker/cookie_api_module_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698