Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 3590011: Update use of SkCanvas and SkDevice to match change in Skia (Closed)

Created:
10 years, 2 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Safari, Evan Martin
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Update use of SkCanvas and SkDevice to match change in Skia: Refactor SkCanvas so that backends don't need to override it - instead take a device factory class. see: http://codereview.appspot.com/2103045/ BUG=New Skia devices required a corresponding canvas TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62813

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit, rebase, roll DEPS #

Patch Set 3 : Bump deps again to bring in fix for memory leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -140 lines) Patch
M DEPS View 2 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_linux.h View 2 chunks +10 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_linux.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 2 chunks +11 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 2 chunks +10 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 2 chunks +3 lines, -12 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas_linux.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M skia/ext/platform_canvas_mac.cc View 4 chunks +3 lines, -14 lines 0 comments Download
M skia/ext/platform_canvas_win.cc View 1 3 chunks +2 lines, -13 lines 0 comments Download
M skia/ext/vector_canvas.h View 2 chunks +1 line, -17 lines 0 comments Download
M skia/ext/vector_canvas.cc View 1 chunk +5 lines, -1 line 0 comments Download
M skia/ext/vector_canvas_linux.cc View 3 chunks +2 lines, -27 lines 0 comments Download
M skia/ext/vector_canvas_win.cc View 2 chunks +2 lines, -38 lines 0 comments Download
M skia/ext/vector_platform_device.h View 1 chunk +5 lines, -0 lines 0 comments Download
M skia/ext/vector_platform_device_linux.h View 2 chunks +13 lines, -0 lines 0 comments Download
M skia/ext/vector_platform_device_linux.cc View 2 chunks +28 lines, -3 lines 0 comments Download
M skia/ext/vector_platform_device_win.h View 2 chunks +12 lines, -0 lines 0 comments Download
M skia/ext/vector_platform_device_win.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vandebo (ex-Chrome)
This is basically just a Skia cleanup, so spreading the review load, feel free to ...
10 years, 2 months ago (2010-10-01 21:39:03 UTC) #1
Evan Martin
I am happy to rubber stamp this, but perhaps it would be good to find ...
10 years, 2 months ago (2010-10-04 19:09:47 UTC) #2
vandebo (ex-Chrome)
I wasn't particularly looking for a rubber stamp. Do you have any reviewer suggestions?
10 years, 2 months ago (2010-10-04 19:37:21 UTC) #3
Evan Martin
On 2010/10/04 19:37:21, vandebo wrote: > I wasn't particularly looking for a rubber stamp. Do ...
10 years, 2 months ago (2010-10-04 20:17:17 UTC) #4
vandebo (ex-Chrome)
I updated the description to be a bit more verbose. I had Mike Reed review ...
10 years, 2 months ago (2010-10-04 20:43:13 UTC) #5
Evan Martin
LGTM http://codereview.chromium.org/3590011/diff/1/9 File skia/ext/platform_canvas.h (right): http://codereview.chromium.org/3590011/diff/1/9#newcode22 skia/ext/platform_canvas.h:22: // transparency: this will enable some optimizations. I ...
10 years, 2 months ago (2010-10-04 20:49:05 UTC) #6
vandebo (ex-Chrome)
http://codereview.chromium.org/3590011/diff/1/9 File skia/ext/platform_canvas.h (right): http://codereview.chromium.org/3590011/diff/1/9#newcode22 skia/ext/platform_canvas.h:22: // transparency: this will enable some optimizations. On 2010/10/04 ...
10 years, 2 months ago (2010-10-14 17:40:15 UTC) #7
Safari
10 years, 2 months ago (2010-10-17 12:20:16 UTC) #8
it does not compile.

  CXX(target)
out/Release/obj.target/skia/skia/ext/bitmap_platform_device_linux.o
In file included from ./skia/ext/bitmap_platform_device.h:17:0,
                 from skia/ext/bitmap_platform_device.cc:5:
./skia/ext/bitmap_platform_device_linux.h:46:68: error: expected class-name
before ‘{’ token
./skia/ext/bitmap_platform_device_linux.h:88:11: error: ‘SkDeviceFactory’ does
not name a type
make: *** [out/Release/obj.target/skia/skia/ext/bitmap_platform_device.o] Error
1

Powered by Google App Engine
This is Rietveld 408576698