Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 3461019: FBTF: Move virtual methods to implementation files. (Closed)

Created:
10 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, fbarchard, ben+cc_chromium.org, Erik does not do reviews, Alpha Left Google, jam, Aaron Boodman, Paweł Hajdan Jr., pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing), James Hawkins, jshin+watch_chromium.org, dhollowa
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Move virtual methods to implementation files. Remove logging.h and other headers where possible. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60369

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Win+chromeos+mac fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -312 lines) Patch
M app/table_model.h View 3 chunks +4 lines, -17 lines 0 comments Download
M app/table_model.cc View 1 chunk +22 lines, -0 lines 1 comment Download
M app/tree_node_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M base/stats_counters.h View 4 chunks +16 lines, -82 lines 0 comments Download
A base/stats_counters.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M base/watchdog.h View 2 chunks +1 line, -4 lines 0 comments Download
M base/watchdog.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browsing_instance.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/browsing_instance.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/simple_content_exceptions_window_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/table_model_array_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/default_encoding_combo_model.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/default_encoding_combo_model.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/device_orientation/provider.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/device_orientation/provider.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crashed_extension_infobar.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/crashed_extension_infobar.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.h View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 5 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 1 chunk +9 lines, -0 lines 1 comment Download
M chrome/browser/external_tab_container_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/history/top_sites_database.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_database.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/language_order_table_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/net/connect_interceptor.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/net/connect_interceptor.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/possible_url_model.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/possible_url_model.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.h View 2 chunks +13 lines, -45 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 2 chunks +63 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/external_host_bindings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/external_host_bindings.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/media/audio_renderer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +9 lines, -15 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M media/base/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/filters.h View 2 chunks +15 lines, -57 lines 0 comments Download
A media/base/filters.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/tools/player_x11/x11_video_renderer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/table/native_table_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/table/table_view2.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/media/buffered_data_source_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Most of these are nits. Some of them actually *do* matter. Obviously the filters.h refactoring ...
10 years, 3 months ago (2010-09-23 21:39:02 UTC) #1
Lei Zhang
10 years, 3 months ago (2010-09-23 22:05:30 UTC) #2
LGTM with nits below:

http://codereview.chromium.org/3461019/diff/5001/6001
File app/table_model.cc (right):

http://codereview.chromium.org/3461019/diff/5001/6001#newcode89
app/table_model.cc:89: NOTREACHED();
can you #include logging.h and not implicitly depend on another header to
#include it?

http://codereview.chromium.org/3461019/diff/5001/6031
File chrome/browser/extensions/extension_infobar_delegate.cc (right):

http://codereview.chromium.org/3461019/diff/5001/6031#newcode62
chrome/browser/extensions/extension_infobar_delegate.cc:62:
AsExtensionInfoBarDelegate() {
style-wise, is this the better way to wrap really long method names or is it
better to write:

ExtensionInfoBarDelegate*
ExtensionInfoBarDelegate::AsExtensionInfoBarDelegate()

?

Powered by Google App Engine
This is Rietveld 408576698