Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/browsing_instance.h

Issue 3461019: FBTF: Move virtual methods to implementation files. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Win+chromeos+mac fixes Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_instance.h
diff --git a/chrome/browser/browsing_instance.h b/chrome/browser/browsing_instance.h
index 491888daf24fc52036f35babd068ebf8736e5be2..fa4ce4998613a64275725834ed0d31e6a0471e56 100644
--- a/chrome/browser/browsing_instance.h
+++ b/chrome/browser/browsing_instance.h
@@ -7,7 +7,6 @@
#pragma once
#include "base/hash_tables.h"
-#include "base/logging.h"
#include "base/ref_counted.h"
#include "chrome/browser/profile.h"
@@ -56,9 +55,7 @@ class SiteInstance;
class BrowsingInstance : public base::RefCounted<BrowsingInstance> {
public:
// Create a new BrowsingInstance.
- explicit BrowsingInstance(Profile* profile)
- : profile_(profile) {
- }
+ explicit BrowsingInstance(Profile* profile);
// Returns whether the process-per-site model is in use (globally or just for
// the given url), in which case we should ensure there is only one
@@ -92,11 +89,7 @@ class BrowsingInstance : public base::RefCounted<BrowsingInstance> {
friend class base::RefCounted<BrowsingInstance>;
// Virtual to allow tests to extend it.
- virtual ~BrowsingInstance() {
- // We should only be deleted when all of the SiteInstances that refer to
- // us are gone.
- DCHECK(site_instance_map_.empty());
- }
+ virtual ~BrowsingInstance();
private:
// Map of site to SiteInstance, to ensure we only have one SiteInstance per

Powered by Google App Engine
This is Rietveld 408576698