Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/extensions/extension_cookies_api.cc

Issue 3461019: FBTF: Move virtual methods to implementation files. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Win+chromeos+mac fixes Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_cookies_api.cc
diff --git a/chrome/browser/extensions/extension_cookies_api.cc b/chrome/browser/extensions/extension_cookies_api.cc
index 81b069062572016b030475f94a1fd724c55e01ee..a1e455ce717e434843a565361223844f0921d32e 100644
--- a/chrome/browser/extensions/extension_cookies_api.cc
+++ b/chrome/browser/extensions/extension_cookies_api.cc
@@ -145,6 +145,8 @@ bool CookiesFunction::ParseStoreContext(const DictionaryValue* details,
GetCookieFunction::GetCookieFunction() {}
+GetCookieFunction::~GetCookieFunction() {}
+
bool GetCookieFunction::RunImpl() {
// Return false if the arguments are malformed.
DictionaryValue* details;
@@ -210,6 +212,8 @@ void GetCookieFunction::RespondOnUIThread() {
GetAllCookiesFunction::GetAllCookiesFunction() : details_(NULL) {}
+GetAllCookiesFunction::~GetAllCookiesFunction() {}
+
bool GetAllCookiesFunction::RunImpl() {
// Return false if the arguments are malformed.
EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details_));
@@ -266,6 +270,9 @@ SetCookieFunction::SetCookieFunction()
success_(false) {
}
+SetCookieFunction::~SetCookieFunction() {
+}
+
bool SetCookieFunction::RunImpl() {
// Return false if the arguments are malformed.
DictionaryValue* details;
@@ -408,6 +415,10 @@ bool RemoveCookieFunction::RunImpl() {
return true;
}
+void RemoveCookieFunction::Run() {
+ SendResponse(RunImpl());
+}
+
bool GetAllCookieStoresFunction::RunImpl() {
Profile* original_profile = profile();
DCHECK(original_profile);
@@ -451,3 +462,7 @@ bool GetAllCookieStoresFunction::RunImpl() {
result_.reset(cookie_store_list);
return true;
}
+
+void GetAllCookieStoresFunction::Run() {
+ SendResponse(RunImpl());
+}

Powered by Google App Engine
This is Rietveld 408576698