FBTF: Move virtual methods to implementation files.

media/base/filters.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Filters are connected in a strongly typed manner, with downstream filters
 // always reading data from upstream filters.  Upstream filters have no clue
 // who is actually reading from them, and return the results via callbacks.
 //
 //                         DemuxerStream(Video) <- VideoDecoder <- VideoRenderer
 // DataSource <- Demuxer <
 //                         DemuxerStream(Audio) <- AudioDecoder <- AudioRenderer
 //
 // Upstream -------------------------------------------------------> Downstream
 //                         <- Reads flow this way
 //                    Buffer assignments flow this way ->
 //
 // Every filter maintains a reference to the scheduler, who maintains data
 // shared between filters (i.e., reference clock value, playback state).  The
 // scheduler is also responsible for scheduling filter tasks (i.e., a read on
 // a VideoDecoder would result in scheduling a Decode task).  Filters can also
 // use the scheduler to signal errors and shutdown playback.
 
 #ifndef MEDIA_BASE_FILTERS_H_
 #define MEDIA_BASE_FILTERS_H_
 
 #include <limits>
 #include <string>
 
 #include "base/callback.h"
-#include "base/logging.h"
-#include "base/message_loop.h"
 #include "base/ref_counted.h"
 #include "base/time.h"
 #include "base/scoped_ptr.h"
 #include "media/base/media_format.h"
 #include "media/base/video_frame.h"
 
+class MessageLoop;
+
 namespace media {
 
 class Buffer;
 class Decoder;
 class DemuxerStream;
 class FilterHost;
 class WritableBuffer;
 
 // Identifies the type of filter implementation.  Used in conjunction with some
 // template wizardry to enforce strongly typed operations.  More or less a
 // knock off of MSVC's __uuidof() operator.
 enum FilterType {
   FILTER_DATA_SOURCE,
   FILTER_DEMUXER,
   FILTER_AUDIO_DECODER,
   FILTER_VIDEO_DECODER,
   FILTER_AUDIO_RENDERER,
   FILTER_VIDEO_RENDERER
 };
 
 // Used for completing asynchronous methods.
 typedef Callback0::Type FilterCallback;
 
 class MediaFilter : public base::RefCountedThreadSafe<MediaFilter> {
  public:
-  MediaFilter() : host_(NULL), message_loop_(NULL) {}
+  MediaFilter();
 
   // Sets the private member |host_|. This is the first method called by
   // the FilterHost after a filter is created.  The host holds a strong
   // reference to the filter.  The reference held by the host is guaranteed
   // to be released before the host object is destroyed by the pipeline.
-  virtual void set_host(FilterHost* host) {
-    DCHECK(host);
-    DCHECK(!host_);
-    host_ = host;
-  }
+  virtual void set_host(FilterHost* host);
 
-  virtual FilterHost* host() {
-    return host_;
-  }
+  virtual FilterHost* host();
 
   // Sets the private member |message_loop_|, which is used by filters for
   // processing asynchronous tasks and maintaining synchronized access to
   // internal data members.  The message loop should be running and exceed the
   // lifetime of the filter.
-  virtual void set_message_loop(MessageLoop* message_loop) {
-    DCHECK(message_loop);
-    DCHECK(!message_loop_);
-    message_loop_ = message_loop;
-  }
+  virtual void set_message_loop(MessageLoop* message_loop);
 
-  virtual MessageLoop* message_loop() {
-    return message_loop_;
-  }
+  virtual MessageLoop* message_loop();
 
   // The pipeline has resumed playback.  Filters can continue requesting reads.
   // Filters may implement this method if they need to respond to this call.
   // TODO(boliu): Check that callback is not NULL in subclasses.
-  virtual void Play(FilterCallback* callback) {
-    DCHECK(callback);
-    if (callback) {
-      callback->Run();
-      delete callback;
-    }
-  }
+  virtual void Play(FilterCallback* callback);
 
   // The pipeline has paused playback.  Filters should stop buffer exchange.
   // Filters may implement this method if they need to respond to this call.
   // TODO(boliu): Check that callback is not NULL in subclasses.
-  virtual void Pause(FilterCallback* callback) {
-    DCHECK(callback);
-    if (callback) {
-      callback->Run();
-      delete callback;
-    }
-  }
+  virtual void Pause(FilterCallback* callback);
 
   // The pipeline has been flushed.  Filters should return buffer to owners.
   // Filters may implement this method if they need to respond to this call.
   // TODO(boliu): Check that callback is not NULL in subclasses.
-  virtual void Flush(FilterCallback* callback) {
-    DCHECK(callback);
-    if (callback) {
-      callback->Run();
-      delete callback;
-    }
-  }
+  virtual void Flush(FilterCallback* callback);
 
   // The pipeline is being stopped either as a result of an error or because
   // the client called Stop().
   // TODO(boliu): Check that callback is not NULL in subclasses.
-  virtual void Stop(FilterCallback* callback) {
-    DCHECK(callback);
-    if (callback) {
-      callback->Run();
-      delete callback;
-    }
-  }
+  virtual void Stop(FilterCallback* callback);
 
   // The pipeline playback rate has been changed.  Filters may implement this
   // method if they need to respond to this call.
-  virtual void SetPlaybackRate(float playback_rate) {}
+  virtual void SetPlaybackRate(float playback_rate);
 
   // Carry out any actions required to seek to the given time, executing the
   // callback upon completion.
-  virtual void Seek(base::TimeDelta time, FilterCallback* callback) {
-    scoped_ptr<FilterCallback> seek_callback(callback);
-    if (seek_callback.get()) {
-      seek_callback->Run();
-    }
-  }
+  virtual void Seek(base::TimeDelta time, FilterCallback* callback);
 
   // This method is called from the pipeline when the audio renderer
   // is disabled. Filters can ignore the notification if they do not
   // need to react to this event.
-  virtual void OnAudioRendererDisabled() {
-  }
+  virtual void OnAudioRendererDisabled();
 
  protected:
   // Only allow scoped_refptr<> to delete filters.
   friend class base::RefCountedThreadSafe<MediaFilter>;
-  virtual ~MediaFilter() {}
+  virtual ~MediaFilter();
 
   FilterHost* host() const { return host_; }
   MessageLoop* message_loop() const { return message_loop_; }
 
  private:
   FilterHost* host_;
   MessageLoop* message_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaFilter);
 };
@@ skipping 224 matching lines @@
   // buffer.
   virtual bool HasEnded() = 0;
 
   // Sets the output volume.
   virtual void SetVolume(float volume) = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_FILTERS_H_