Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/metrics/metrics_log.cc

Issue 3461019: FBTF: Move virtual methods to implementation files. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Win+chromeos+mac fixes Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/metrics_log.h" 5 #include "chrome/browser/metrics/metrics_log.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 } 76 }
77 77
78 std::string version = version_info.Version(); 78 std::string version = version_info.Version();
79 if (!version_extension_.empty()) 79 if (!version_extension_.empty())
80 version += version_extension_; 80 version += version_extension_;
81 if (!version_info.IsOfficialBuild()) 81 if (!version_info.IsOfficialBuild())
82 version.append("-devel"); 82 version.append("-devel");
83 return version; 83 return version;
84 } 84 }
85 85
86 MetricsLog* MetricsLog::AsMetricsLog() {
87 return this;
88 }
89
86 void MetricsLog::RecordIncrementalStabilityElements() { 90 void MetricsLog::RecordIncrementalStabilityElements() {
87 DCHECK(!locked_); 91 DCHECK(!locked_);
88 92
89 PrefService* pref = g_browser_process->local_state(); 93 PrefService* pref = g_browser_process->local_state();
90 DCHECK(pref); 94 DCHECK(pref);
91 95
92 OPEN_ELEMENT_FOR_SCOPE("profile"); 96 OPEN_ELEMENT_FOR_SCOPE("profile");
93 WriteCommonEventAttributes(); 97 WriteCommonEventAttributes();
94 98
95 WriteInstallElement(); // Supply appversion. 99 WriteInstallElement(); // Supply appversion.
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 const std::string result_type(AutocompleteMatch::TypeToString(i->type)); 444 const std::string result_type(AutocompleteMatch::TypeToString(i->type));
441 if (!result_type.empty()) 445 if (!result_type.empty())
442 WriteAttribute("resulttype", result_type); 446 WriteAttribute("resulttype", result_type);
443 WriteIntAttribute("relevance", i->relevance); 447 WriteIntAttribute("relevance", i->relevance);
444 WriteIntAttribute("isstarred", i->starred ? 1 : 0); 448 WriteIntAttribute("isstarred", i->starred ? 1 : 0);
445 } 449 }
446 } 450 }
447 451
448 ++num_events_; 452 ++num_events_;
449 } 453 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698