Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6295)

Unified Diff: chrome/browser/extensions/extension_cookies_api.h

Issue 3461019: FBTF: Move virtual methods to implementation files. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Win+chromeos+mac fixes Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_cookies_api.h
diff --git a/chrome/browser/extensions/extension_cookies_api.h b/chrome/browser/extensions/extension_cookies_api.h
index 0ecb4e3c4e35a7a98664833fc0e134c027724367..50b922b4da6cf9c4e2cd3df9b30f2bd420d5de11 100644
--- a/chrome/browser/extensions/extension_cookies_api.h
+++ b/chrome/browser/extensions/extension_cookies_api.h
@@ -94,6 +94,7 @@ class CookiesFunction : public AsyncExtensionFunction {
class GetCookieFunction : public CookiesFunction {
public:
GetCookieFunction();
+ ~GetCookieFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("cookies.get")
@@ -112,6 +113,7 @@ class GetCookieFunction : public CookiesFunction {
class GetAllCookiesFunction : public CookiesFunction {
public:
GetAllCookiesFunction();
+ ~GetAllCookiesFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("cookies.getAll")
@@ -130,6 +132,7 @@ class GetAllCookiesFunction : public CookiesFunction {
class SetCookieFunction : public CookiesFunction {
public:
SetCookieFunction();
+ ~SetCookieFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("cookies.set")
@@ -154,9 +157,7 @@ class RemoveCookieFunction : public CookiesFunction {
public:
virtual bool RunImpl();
// RemoveCookieFunction is sync.
- virtual void Run() {
- SendResponse(RunImpl());
- }
+ virtual void Run();
DECLARE_EXTENSION_FUNCTION_NAME("cookies.remove")
};
@@ -165,9 +166,7 @@ class GetAllCookieStoresFunction : public CookiesFunction {
public:
virtual bool RunImpl();
// GetAllCookieStoresFunction is sync.
- virtual void Run() {
- SendResponse(RunImpl());
- }
+ virtual void Run();
DECLARE_EXTENSION_FUNCTION_NAME("cookies.getAllCookieStores")
};

Powered by Google App Engine
This is Rietveld 408576698