Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: app/table_model.h

Issue 3461019: FBTF: Move virtual methods to implementation files. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Win+chromeos+mac fixes Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | app/table_model.cc » ('j') | app/table_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/table_model.h
diff --git a/app/table_model.h b/app/table_model.h
index 60637f0ea6d929d925f26380f44054fd77b30f56..baae39031926b3c0f8ceb2fdb1e9a88ff3d5581a 100644
--- a/app/table_model.h
+++ b/app/table_model.h
@@ -9,7 +9,6 @@
#include <string>
#include <vector>
-#include "base/logging.h"
#include "unicode/coll.h"
class SkBitmap;
@@ -44,9 +43,7 @@ class TableModel {
// Returns the tooltip, if any, to show for a particular row. If there are
// multiple columns in the row, this will only be shown when hovering over
// column zero.
- virtual std::wstring GetTooltip(int row) {
- return std::wstring();
- }
+ virtual std::wstring GetTooltip(int row);
// Returns true if the TableView has groups. Groups provide a way to visually
// delineate the rows in a table view. When groups are enabled table view
@@ -54,25 +51,15 @@ class TableModel {
// the group.
//
// On win2k a visual separator is not rendered for the group headers.
- virtual bool HasGroups() { return false; }
+ virtual bool HasGroups();
// Returns the groups.
// This is only used if HasGroups returns true.
- virtual Groups GetGroups() {
- // If you override HasGroups to return true, you must override this as
- // well.
- NOTREACHED();
- return std::vector<Group>();
- }
+ virtual Groups GetGroups();
// Returns the group id of the specified row.
// This is only used if HasGroups returns true.
- virtual int GetGroupID(int row) {
- // If you override HasGroups to return true, you must override this as
- // well.
- NOTREACHED();
- return 0;
- }
+ virtual int GetGroupID(int row);
// Sets the observer for the model. The TableView should NOT take ownership
// of the observer.
« no previous file with comments | « no previous file | app/table_model.cc » ('j') | app/table_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698