Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 3195022: Move code stubs from codegen*.* files to code-stub*.* files. (Closed)

Created:
10 years, 4 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move code stub implementations from codegen-[platform].cc files to new code-stub-[platform].cc files, and declarations to new code-stub-[platform].h files. Remaining work is to do the same for platform-independent code stub declarations, and to remove all dependencies on codegen header files from code stub files. Committed: http://code.google.com/p/v8/source/detail?r=5338

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14653 lines, -14360 lines) Patch
M src/SConscript View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
A src/arm/code-stubs-arm.h View 2 3 4 1 chunk +475 lines, -0 lines 0 comments Download
A src/arm/code-stubs-arm.cc View 2 3 1 chunk +4778 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.h View 1 2 1 chunk +0 lines, -504 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 2 3 6 chunks +39 lines, -4708 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/ic-arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A src/ia32/code-stubs-ia32.h View 2 3 4 1 chunk +362 lines, -0 lines 0 comments Download
A src/ia32/code-stubs-ia32.cc View 2 3 1 chunk +4539 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 2 1 chunk +0 lines, -321 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 3 4 chunks +1 line, -4495 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 3 1 chunk +1 line, -0 lines 0 comments Download
A src/x64/code-stubs-x64.h View 2 3 4 1 chunk +392 lines, -0 lines 0 comments Download
A src/x64/code-stubs-x64.cc View 2 3 1 chunk +4016 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 2 1 chunk +0 lines, -351 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 2 3 4 chunks +1 line, -3972 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 10 chunks +12 lines, -8 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 2 1 chunk +8 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 2 1 chunk +8 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
This change only moves functions and declarations to new files, and adds #includes, in order ...
10 years, 4 months ago (2010-08-24 14:50:06 UTC) #1
Lasse Reichstein
LGTM so far. I haven't checked the code, assuming it's just moved. http://codereview.chromium.org/3195022/diff/8001/12001 File src/arm/code-stubs-arm.h ...
10 years, 4 months ago (2010-08-25 07:17:59 UTC) #2
Kevin Millikin (Chromium)
Nitpick: code-stubs comes before codegen, you have it after everywhere in this changelist. http://codereview.chromium.org/3195022/diff/8001/9001 File ...
10 years, 4 months ago (2010-08-25 08:30:54 UTC) #3
William Hesse
10 years, 4 months ago (2010-08-25 09:45:29 UTC) #4
Ordering changed in all files.  XCode project updated.

Powered by Google App Engine
This is Rietveld 408576698