Transparency

Pull WebKit deps to get transparency fixes, and rebaseline affected layout tests.

Add a helper class to manage Windows' transparency issues. It will create layers
and manage transforms in such a way that most effects can be achieved with
fonts and form controls on Windows while looking nice.

This removes the magic transparency color and associated infrastructure since
it is no longer needed.

This fixes semitransparent ClearType antialiasing and pngs with alpha channels
with opacity applied.

BUG=559, 2791, 3229, 6372
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10637

[dglazkov, 2009-02-23 19:08:58]

Looks Great with the exception of HTTP layout tests being rebaselined to "500
Server Error" thing.

I must say I felt like I was in Willy Wonka 's Factory in some parts of the
code: I know it's chocolate, I just have no idea how it's made.

Some style nits below:

http://codereview.chromium.org/21201/diff/2004/3004
File third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
(right):

http://codereview.chromium.org/21201/diff/2004/3004#newcode79
Line 79: class FontHelper {
I don't like *Helper notation, it's not very _helpful_ (rimshot!) in
understanding what it actually helpful with.

How about TransparencyAwareFont or somesuch?

http://codereview.chromium.org/21201/diff/2004/3004#newcode130
Line 130: if (m_useGDI) {
invert and early return?

http://codereview.chromium.org/21201/diff/2004/3004#newcode177
Line 177: if (m_useGDI) {
Invert and early return?

http://codereview.chromium.org/21201/diff/2004/3003
File
third_party/WebKit/WebCore/platform/graphics/chromium/TransparencyHelperWin.cpp
(right):

http://codereview.chromium.org/21201/diff/2004/3003#newcode1
Line 1: /*
Here and elsewhere: this is an older version of our header -- take one from
V8Proxy.h.

http://codereview.chromium.org/21201/diff/2004/3003#newcode60
Line 60: 
I think the updated, unofficial consensus on const naming style is just
camelCase, no prefixes.

http://codereview.chromium.org/21201/diff/2004/3005
File
third_party/WebKit/WebCore/platform/graphics/chromium/TransparencyHelperWin.h
(right):

http://codereview.chromium.org/21201/diff/2004/3005#newcode49
Line 49: class TransparencyHelperWin {
What about just calling it TransparencyWin? "Helper" seems unnecessary here.

http://codereview.chromium.org/21201/diff/2004/3005#newcode52
Line 52: // No extra layer is created. Drawing will happen to the source.
enum naming convention:
https://lists.webkit.org/pipermail/webkit-dev/2008-October/005176.html

http://codereview.chromium.org/21201/diff/2004/3005#newcode101
Line 101: // There are no changes to the transform. Use this when drawing
Ditto here.

http://codereview.chromium.org/21201/diff/2004/3005#newcode124
Line 124: void Init(GraphicsContext* dest,
lower-case

http://codereview.chromium.org/21201/diff/2004/3005#newcode214
Line 214: std::auto_ptr<ImageBuffer> m_ownedBuffer;
OwnPtr?

http://codereview.chromium.org/21201/diff/2004/3022
File third_party/WebKit/WebCore/rendering/RenderThemeChromiumWin.cpp (right):

http://codereview.chromium.org/21201/diff/2004/3022#newcode59
Line 59: {
I've seen this guy elsewhere. Can we move it to the TransparencyHelperWin
perhaps to reduce duplication?

http://codereview.chromium.org/21201/diff/2004/3022#newcode66
Line 66: public:
So maybe the right name for TransparencyHelperWin would be
TransparencyAwarePainterWin? :)

[dglazkov, 2009-02-23 21:18:22]

LGTM!