Force inclusion of build/common.gypi for all chromium gyp files.

Force inclusion of build/common.gypi for all chromium gyp files.

Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.

What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 
5. build/common.gypi was left empty, because there are some external projects that still refer to it.

Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi 
  ./third_party/hunspell/hunspell.gyp
  ./third_party/icu/icu.gyp
  ./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi 
   -or-
   Delete gyp_chromium.gypi and move its content back to common.gypi

Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.

Committed: http://src.chromium.org/viewvc/chrome/trunk/26302

[Mark Mentovai, 2009-09-15 13:52:26]

You can revise icu.gyp and hunspell.gyp yourself.  They're in the Chromium
repository, just in a separate DEPS partition.  I can help you with v8.gyp.

http://codereview.chromium.org/206006/diff/1/2
File DEPS (right):

http://codereview.chromium.org/206006/diff/1/2#newcode156
Line 156: "pattern": "\\.gypi?$|[/\\\\]src[/\\\\]tools[/\\\\]gyp[/\\\\]",
This is what I meant when I said you had to adjust the "left hand side" of the
hook.  You want the hook to trigger when src/build/gyp_chromium changes, so you
need to add it to the pattern here.

http://codereview.chromium.org/206006/diff/1/3
File app/app.gyp (right):

http://codereview.chromium.org/206006/diff/1/3#newcode9
Line 9: 'includes': [
Don't leave an empty includes section behind, just take the includes section
out.

[yaar, 2009-09-15 17:06:50]

On 2009/09/15 13:52:26, Mark Mentovai wrote:
> You can revise icu.gyp and hunspell.gyp yourself.  They're in the Chromium
> repository, just in a separate DEPS partition.  I can help you with v8.gyp.

Here are the hunspell and icu changes:
hunspell: http://codereview.chromium.org/201117
icu: http://codereview.chromium.org/195087
Once they are landed, I'll update chromium's DEPS file to the right revision.

Mark, can you fix v8 while I work on the rest of the issues?

[yaar, 2009-09-15 21:03:04]

Mark's feedback is incorporated. The DEPS file is updated with icu, hunspell and
v8's new revisions. I also fixed the strange include in build/linux/system.gypi.

Tested on mac, win, linux try bots.

[Mark Mentovai, 2009-09-15 21:20:50]

Getting closer.

http://codereview.chromium.org/206006/diff/5001/5002
File DEPS (right):

http://codereview.chromium.org/206006/diff/5001/5002#newcode156
Line 156: "pattern":
"\\.gypi?$|[/\\\\]src[/\\\\]build[/\\\\]gyp_chromium[/\\\\]",
No, we want to keep src/tools/gyp in the pattern too, so that we re-run the hook
if GYP itself changes.

When you put gyp_chromium in the hook, you can anchor the end of it with a $,
because we want to just match that file, not anything else that might begin with
that substring.

http://codereview.chromium.org/206006/diff/5001/5008
File build/gyp_chromium (right):

http://codereview.chromium.org/206006/diff/5001/5008#newcode1
Line 1: #!/usr/bin/python
svn propset svn:executable '*' gyp_chromium
svn propset svn:eol-style LF gyp_chromium

http://codereview.chromium.org/206006/diff/5001/5009
File build/gyp_chromium.gypi (right):

http://codereview.chromium.org/206006/diff/5001/5009#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Did you create this file with svn copy?  Sometimes you can't tell with Rietveld.

If you didn't, please go back and create it with svn copy:

svn remove gyp_chromium.gypi
svn revert common.gypi
svn copy common.gypi gyp_chromium.gypi
svn remove common.gypi

There's a lot of change history in this file, and we want to preserve it.

http://codereview.chromium.org/206006/diff/5001/5030
File o3d/build/gyp_o3d (right):

http://codereview.chromium.org/206006/diff/5001/5030#newcode1
Line 1: #!/usr/bin/python
svn propset svn:executable '*' gyp_o3d
svn propset svn:eol-style LF gyp_o3d

[yaar, 2009-09-15 21:45:14]

1. Since nobody is directly using common.gypi anymore, I just moved all the
content back to it from gyp_chromium.gypi and deleted the later.
2. pattern fixed.
3. The svn properties of o3d_gyp will be done as a separate patch (I'm using git
for this one).

[Mark Mentovai, 2009-09-15 21:49:56]

LGTM

http://codereview.chromium.org/206006/diff/70/76
File build/common.gypi (right):

http://codereview.chromium.org/206006/diff/70/76#newcode8
Line 8: {
Nit: leave a blank line between your comment block and the {.

http://codereview.chromium.org/206006/diff/70/95
File o3d/DEPS_gyp (right):

http://codereview.chromium.org/206006/diff/70/95#newcode147
Line 147: "pattern":
"\\.gypi?$|[/\\\\]src[/\\\\]tools[/\\\\]gyp[/\\\\]|MANIFEST$",
Fix the pattern here too to reference src/build/gyp_o3d in the same way that we
did for gyp_chromium.

http://codereview.chromium.org/206006/diff/70/95#newcode148
Line 148: "action": ["python", "build/gyp_o3d", "build/all.gyp", "--depth",
"."],
Shouldn't this be o3d/build/gyp_o3d and o3d/build/all.gyp?