Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5040)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/installer.gyp

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)
Patch Set: 2nd round of feedback Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « chrome/chrome.gyp ('k') | chrome/installer/mini_installer.gyp » ('j') | o3d/DEPS_gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/installer.gyp
diff --git a/chrome/installer/installer.gyp b/chrome/installer/installer.gyp
index d5f3643beeff612495ef8992cc0ec6551ed96898..f2569f73b3eb65f70975153cb57a1c7cc439675c 100644
--- a/chrome/installer/installer.gyp
+++ b/chrome/installer/installer.gyp
@@ -5,9 +5,6 @@
'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE',
# 'branding_dir' is set in the 'conditions' section at the bottom.
},
- 'includes': [
- '../../build/common.gypi',
- ],
'conditions': [
['OS=="win"', {
'targets': [
« build/common.gypi ('K') | « chrome/chrome.gyp ('k') | chrome/installer/mini_installer.gyp » ('j') | o3d/DEPS_gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698