o3d/DEPS_gyp - Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: o3d/DEPS_gyp

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)

Patch Set: 2nd round of feedback Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 vars = {	1 vars = {

2 "chromium_trunk": "http://src.chromium.org/svn/trunk",	2 "chromium_trunk": "http://src.chromium.org/svn/trunk",

3 "nixysa_rev": "54",	3 "nixysa_rev": "54",

4 "chromium_rev": "22547",	4 "chromium_rev": "22547",

5 "o3d_code_rev": "145",	5 "o3d_code_rev": "145",

6 "skia_rev": "279",	6 "skia_rev": "279",

7 "gyp_rev": "626",	7 "gyp_rev": "626",

8 "gtest_rev": "267",	8 "gtest_rev": "267",

9 "gflags_rev": "30",	9 "gflags_rev": "30",

10 "breakpad_rev": "346",	10 "breakpad_rev": "346",

(...skipping 126 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
137 "unix": {	137 "unix": {

138 # Linux, really.	138 # Linux, really.

139 "site_scons":	139 "site_scons":

140 Var("chromium_trunk") + "/src/site_scons@" + Var("chromium_rev"),	140 Var("chromium_trunk") + "/src/site_scons@" + Var("chromium_rev"),

141 },	141 },

142 }	142 }

143	143

144 hooks = [	144 hooks = [

145 {	145 {

146 # A change to a .gyp, .gypi, or to GYP itself shound run the generator.	146 # A change to a .gyp, .gypi, or to GYP itself shound run the generator.

147 "pattern": "\\.gypi?$\|[/\\\\]src[/\\\\]tools[/\\\\]gyp[/\\\\]\|MANIFEST$",	147 "pattern": "\\.gypi?$\|[/\\\\]src[/\\\\]tools[/\\\\]gyp[/\\\\]\|MANIFEST$",
	Mark Mentovai 2009/09/15 21:49:57 Fix the pattern here too to reference src/build/gy Fix the pattern here too to reference src/build/gyp_o3d in the same way that we did for gyp_chromium.
148 "action": ["python", "tools/gyp/gyp", "o3d/build/all.gyp", "--depth", "."],	148 "action": ["python", "build/gyp_o3d", "build/all.gyp", "--depth", "."],
	Mark Mentovai 2009/09/15 21:49:57 Shouldn't this be o3d/build/gyp_o3d and o3d/build/ Shouldn't this be o3d/build/gyp_o3d and o3d/build/all.gyp?
149 },	149 },

150 ]	150 ]

OLD	NEW

« build/common.gypi ('K') | « net/tools/tld_cleanup/tld_cleanup.gyp ('k') | o3d/build/all.gyp » ('j') | no next file with comments »