chrome/installer/mini_installer.gyp - Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer.gyp

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)

Patch Set: 2nd round of feedback Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mini_installer.gyp

diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp

index 4389884e4d0177fde2c5c1d9838a4d7848cb7712..e48ed62a83be775409a5ebb38939d24196bb15ec 100755

--- a/chrome/installer/mini_installer.gyp

+++ b/chrome/installer/mini_installer.gyp

@@ -7,9 +7,6 @@

'msvs_use_common_release': 0,

'msvs_use_common_linker_extras': 0,

- 'includes': [

- '../../build/common.gypi',

- ],

'conditions': [

['OS=="win"', {

'targets': [